Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up reading metadata from file #84

Conversation

argerus
Copy link
Contributor

@argerus argerus commented Oct 17, 2024

Added buffered read.

Loading a 19 MB file went from ~9 seconds -> 90 milliseconds.

@erikbosch
Copy link
Contributor

To be included in 0.5

@SebastianSchildt
Copy link
Contributor

That is an efficient use of 1 additional LoC :D 👍

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 50.02%. Comparing base (918f16a) to head (dd694ef).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
databroker/src/main.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
- Coverage   50.03%   50.02%   -0.01%     
==========================================
  Files          31       31              
  Lines       11804    11805       +1     
==========================================
  Hits         5906     5906              
- Misses       5898     5899       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.
lgtm 🪭

@SebastianSchildt SebastianSchildt merged commit 81a15f1 into eclipse-kuksa:main Oct 21, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants