Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dep Update #85

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Dep Update #85

merged 1 commit into from
Oct 18, 2024

Conversation

erikbosch
Copy link
Contributor

@erikbosch erikbosch commented Oct 17, 2024

Possibly fixes build error

Changed by cargo update

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.03%. Comparing base (1247130) to head (9c066a2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   49.94%   50.03%   +0.08%     
==========================================
  Files          31       31              
  Lines       11805    11804       -1     
==========================================
+ Hits         5896     5906      +10     
+ Misses       5909     5898      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erikbosch erikbosch marked this pull request as ready for review October 17, 2024 13:45
@erikbosch
Copy link
Contributor Author

@argerus @rafaeling - I noticed that unit tests on your PRs failed as well as on master. Updating dependencies seems to solve it. Could it possibly be that llvm needed a newer libc?

@lukasmittag
Copy link
Contributor

lukasmittag commented Oct 18, 2024

Why only update Cargo.lock and not the toml as well?

Note: only lock file needed to be updated toml already is.

Copy link
Contributor

@lukasmittag lukasmittag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasmittag lukasmittag merged commit 918f16a into eclipse-kuksa:main Oct 18, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants