Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update incomplete information on errors #87

Conversation

rafaeling
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 58.77%. Comparing base (a8df2f6) to head (59265ab).
Report is 6 commits behind head on feature/databroker-api-v2.

Files with missing lines Patch % Lines
databroker/src/grpc/kuksa_val_v2/conversions.rs 33.33% 2 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##           feature/databroker-api-v2      #87      +/-   ##
=============================================================
+ Coverage                      55.33%   58.77%   +3.44%     
=============================================================
  Files                             33       33              
  Lines                          14677    15531     +854     
=============================================================
+ Hits                            8121     9129    +1008     
+ Misses                          6556     6402     -154     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rafaeling rafaeling marked this pull request as draft October 24, 2024 13:56
@rafaeling rafaeling changed the title Extend open provider stream error documentation Update incomplete information on errors Oct 24, 2024
@rafaeling rafaeling marked this pull request as ready for review October 24, 2024 14:54
Copy link
Contributor

@erikbosch erikbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaeling rafaeling merged commit 95e3041 into eclipse-kuksa:feature/databroker-api-v2 Oct 29, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants