Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of actuator type on actuate and batch_actuate and extend UpdateErrors #90

Conversation

rafaeling
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 44.09449% with 71 lines in your changes missing coverage. Please review.

Project coverage is 58.94%. Comparing base (3368c07) to head (62552a5).
Report is 4 commits behind head on feature/databroker-api-v2.

Files with missing lines Patch % Lines
databroker/src/broker.rs 59.74% 31 Missing ⚠️
databroker/src/grpc/kuksa_val_v2/conversions.rs 20.00% 16 Missing ⚠️
databroker/src/grpc/kuksa_val_v1/val.rs 27.77% 13 Missing ⚠️
databroker/src/viss/v2/server.rs 0.00% 8 Missing ⚠️
...tabroker/src/grpc/sdv_databroker_v1/conversions.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##           feature/databroker-api-v2      #90      +/-   ##
=============================================================
- Coverage                      59.15%   58.94%   -0.22%     
=============================================================
  Files                             33       33              
  Lines                          15805    15867      +62     
=============================================================
+ Hits                            9350     9353       +3     
- Misses                          6455     6514      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

databroker/src/broker.rs Outdated Show resolved Hide resolved
databroker/src/broker.rs Outdated Show resolved Hide resolved
@rafaeling rafaeling changed the title Validation of actuator type on actuate and batch_actuate and some more errors Validation of actuator type on actuate and batch_actuate and extend UpdateErrors Oct 31, 2024
databroker/src/types.rs Outdated Show resolved Hide resolved
@rafaeling rafaeling force-pushed the feature/missing_errors_and_check_correct_actuation branch from 9e6da1b to 62552a5 Compare November 4, 2024 08:10
Copy link
Contributor

@erikbosch erikbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is good enough now

@rafaeling rafaeling merged commit 54755f0 into eclipse-kuksa:feature/databroker-api-v2 Nov 4, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants