-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[skip ci] Update minimum supported compiler levels and fix documentation links #7479
Conversation
@mstoodle please review. @ThanHenderson FYI Note that this PR updates the minimum supported compiler section only. More work is required to clean up the rest of the document on what features are actually supported (or not), so the original issue will remain open. |
Great. Thanks.
Now that the versions are documented, I can run through that list and shuffle around the features that are now supported. iirc from my initial investigation, all the compilers save for xlC are C++11 feature complete. |
doc/SupportedC++Features.md
Outdated
Linux | s390x | g++ | [7.3](https://gcc.gnu.org/onlinedocs/7.3.0/) | ||
Linux | ppc64le | g++ | [7.3](https://gcc.gnu.org/onlinedocs/7.3.0/) | ||
Linux | ppc64le | XLC | [12.1](https://www.ibm.com/support/pages/system/files/support/swg/swgdocs.nsf/0/330533a7bf467181852579ad001c960f/$FILE/compiler.pdf) | ||
AIX | ppc64 | XLC | [12.1](https://www.ibm.com/support/pages/system/files/support/swg/swgdocs.nsf/0/330533a7bf467181852579ad001c960f/$FILE/compiler.pdf) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these versions for Linux and AIX XLC compilers correct? From the conversation in the issue, I think 13.1.3 is the minimum version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you're right. Thanks for spotting that.
While it is a nice-to-have for the 0.3.0 release, I don't think that it is as "urgent" as updating and documenting the minimum compiler levels supported. If that is something you'd be able to do by the end of the week then we can wait (let me know). Otherwise, once this PR is merged I will publish the 0.3.0 release. |
Also add missing platforms (Arm Linux and macOS). Removed XLC for Linux as Eclipse OMR does not have a means of evaluating the latest compiler versions as part of its CI builds. Signed-off-by: Daryl Maier <[email protected]>
Given eclipse-openj9/openj9#20304. The features moved from the supported features list in PR #7369 should be moved back to the unsupported features list. Could you add that here? If not, I'll open another PR. That PR moved the features that were labelled as blocked by only |
I want to keep this PR just for the compiler levels. If there are changes to the supported features please contribute in a separate PR. |
@kevindean12 : please confirm you have no issues with this proposal by approving |
@dibyendumajumdar I would guess that you're using at least these levels, but since we're moving things forward, I just thought I'd check in with you for awareness at the very least... |
thank you - its fine by me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @0xdaryl
not sure if this will work, but worth a try [skip ci] |
Also add missing platforms (Arm Linux and macOS).
Removed XLC for Linux as Eclipse OMR does not have a means of evaluating
the latest compiler versions as part of its CI builds.
Issue #7359