Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip ci] Update minimum supported compiler levels and fix documentation links #7479

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

0xdaryl
Copy link
Contributor

@0xdaryl 0xdaryl commented Oct 3, 2024

Also add missing platforms (Arm Linux and macOS).

Removed XLC for Linux as Eclipse OMR does not have a means of evaluating
the latest compiler versions as part of its CI builds.

Issue #7359

@0xdaryl
Copy link
Contributor Author

0xdaryl commented Oct 3, 2024

@mstoodle please review.

@ThanHenderson FYI

Note that this PR updates the minimum supported compiler section only. More work is required to clean up the rest of the document on what features are actually supported (or not), so the original issue will remain open.

@ThanHenderson
Copy link
Contributor

Great. Thanks.

More work is required to clean up the rest of the document on what features are actually supported (or not)

Now that the versions are documented, I can run through that list and shuffle around the features that are now supported. iirc from my initial investigation, all the compilers save for xlC are C++11 feature complete.

Linux | s390x | g++ | [7.3](https://gcc.gnu.org/onlinedocs/7.3.0/)
Linux | ppc64le | g++ | [7.3](https://gcc.gnu.org/onlinedocs/7.3.0/)
Linux | ppc64le | XLC | [12.1](https://www.ibm.com/support/pages/system/files/support/swg/swgdocs.nsf/0/330533a7bf467181852579ad001c960f/$FILE/compiler.pdf)
AIX | ppc64 | XLC | [12.1](https://www.ibm.com/support/pages/system/files/support/swg/swgdocs.nsf/0/330533a7bf467181852579ad001c960f/$FILE/compiler.pdf)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these versions for Linux and AIX XLC compilers correct? From the conversation in the issue, I think 13.1.3 is the minimum version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right. Thanks for spotting that.

@0xdaryl
Copy link
Contributor Author

0xdaryl commented Oct 3, 2024

Now that the versions are documented, I can run through that list and shuffle around the features that are now supported. iirc from my initial investigation, all the compilers save for xlC are C++11 feature complete.

While it is a nice-to-have for the 0.3.0 release, I don't think that it is as "urgent" as updating and documenting the minimum compiler levels supported. If that is something you'd be able to do by the end of the week then we can wait (let me know). Otherwise, once this PR is merged I will publish the 0.3.0 release.

Also add missing platforms (Arm Linux and macOS).

Removed XLC for Linux as Eclipse OMR does not have a means of evaluating
the latest compiler versions as part of its CI builds.

Signed-off-by: Daryl Maier <[email protected]>
@ThanHenderson
Copy link
Contributor

Given eclipse-openj9/openj9#20304. The features moved from the supported features list in PR #7369 should be moved back to the unsupported features list. Could you add that here? If not, I'll open another PR.

That PR moved the features that were labelled as blocked by only gcc 4.4.7 to the supported features list; it is clear now though that it is XLC on z/OS that is the blocker.

@0xdaryl
Copy link
Contributor Author

0xdaryl commented Oct 8, 2024

I want to keep this PR just for the compiler levels. If there are changes to the supported features please contribute in a separate PR.

@0xdaryl
Copy link
Contributor Author

0xdaryl commented Oct 8, 2024

@kevindean12 : please confirm you have no issues with this proposal by approving

@mstoodle
Copy link
Contributor

mstoodle commented Oct 8, 2024

@dibyendumajumdar I would guess that you're using at least these levels, but since we're moving things forward, I just thought I'd check in with you for awareness at the very least...

@dibyendumajumdar
Copy link
Contributor

@dibyendumajumdar I would guess that you're using at least these levels, but since we're moving things forward, I just thought I'd check in with you for awareness at the very least...

thank you - its fine by me.

Copy link
Contributor

@mstoodle mstoodle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @0xdaryl

@mstoodle
Copy link
Contributor

not sure if this will work, but worth a try

[skip ci]

@mstoodle mstoodle changed the title Update minimum supported compiler levels and fix documentation links [skip ci] Update minimum supported compiler levels and fix documentation links Oct 10, 2024
@mstoodle mstoodle merged commit 7119f67 into eclipse-omr:master Oct 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants