Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x86: Add disableAVX2/512 options and check XCR0 for OS support #7510

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

BradleyWood
Copy link
Contributor

No description provided.

@BradleyWood
Copy link
Contributor Author

jenkins build all

@BradleyWood
Copy link
Contributor Author

I suspect this change will fix eclipse-openj9/openj9#19408 on windows server 2012.

@BradleyWood
Copy link
Contributor Author

FYI, @0xdaryl @JamesKingdon @hzongaro

compiler/x/env/OMRCPU.cpp Outdated Show resolved Hide resolved
@BradleyWood BradleyWood force-pushed the xcro_flags branch 2 times, most recently from 1e9014f to 0af240b Compare November 7, 2024 15:32
@0xdaryl
Copy link
Contributor

0xdaryl commented Nov 7, 2024

Jenkins build all

@BradleyWood
Copy link
Contributor Author

Builds don't run on draft PRs. I will undraft, but please don't merge until I can test on different system configurations.

@BradleyWood BradleyWood marked this pull request as ready for review November 7, 2024 15:48
@BradleyWood BradleyWood requested a review from mstoodle as a code owner November 7, 2024 15:48
@0xdaryl 0xdaryl changed the title x86: Add disableAVX2/512 options and check XCR0 for OS support WIP: x86: Add disableAVX2/512 options and check XCR0 for OS support Nov 7, 2024
@0xdaryl
Copy link
Contributor

0xdaryl commented Nov 7, 2024

Added WIP to the title.

@BradleyWood
Copy link
Contributor Author

Jenkins build all

@BradleyWood BradleyWood changed the title WIP: x86: Add disableAVX2/512 options and check XCR0 for OS support x86: Add disableAVX2/512 options and check XCR0 for OS support Nov 19, 2024
@BradleyWood BradleyWood marked this pull request as draft November 25, 2024 17:12
@BradleyWood
Copy link
Contributor Author

I found an issue with TR_DisableAVX in openJ9 without this PR. I am investigating.

@BradleyWood BradleyWood marked this pull request as ready for review December 5, 2024 15:48
@BradleyWood BradleyWood requested a review from dsouzai as a code owner December 5, 2024 15:48
@BradleyWood
Copy link
Contributor Author

jenkins build all

@BradleyWood
Copy link
Contributor Author

@0xdaryl Can you take another review of this PR. I expect it will fix eclipse-openj9/openj9#19408 and customer issue. Would be nice to get those fixed for 0.49, if possible.

@BradleyWood
Copy link
Contributor Author

This PR shouldn't break J9. However, J9 doesn't respect when OMR disables features. eclipse-openj9/openj9#20691 will be required to use any of these options.

@BradleyWood
Copy link
Contributor Author

jenkins build all

@0xdaryl 0xdaryl merged commit 3b178a4 into eclipse-omr:master Dec 11, 2024
11 of 13 checks passed
@0xdaryl
Copy link
Contributor

0xdaryl commented Dec 17, 2024

@BradleyWood : in case it wasn't apparent, while you were away this PR was reverted because of Windows compile failures.

The issue was with the undefined compilation symbol in the OMR::X86::CPU::is_feature_disabled(uint32_t feature) function. Given that a CPU class is attached to every compilation object now, it makes sense to cache the compilation object in the CPU class if it exists for just these kinds of checks. Of course, a NULL compilation object is still a possibility if this class is used outside of the JIT or in early/late initialization. However, I'll let you consider the alternatives for how to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants