Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New CML option to adjust storage of extra startup hints #1462

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sreekala-Gopakumar
Copy link
Contributor

#1433

New parameter 'extraStartupHints` added to the -Xshareclasses topic.

Closes #1433
Signed-off-by: Sreekala Gopakumar [email protected]

@Sreekala-Gopakumar
Copy link
Contributor Author

Jenkins doc stage

@Sreekala-Gopakumar
Copy link
Contributor Author

Jenkins doc stage

@Sreekala-Gopakumar
Copy link
Contributor Author

Jenkins doc stage

@Sreekala-Gopakumar
Copy link
Contributor Author

Jenkins doc stage

@Sreekala-Gopakumar
Copy link
Contributor Author

@hangshao0 - I have updated the documents. Please check and confirm. Thanks!

@tajila
Copy link
Contributor

tajila commented Dec 17, 2024

@pshipton Please take a look


: Adjusts the number of startup hints that can be stored in a shared cache. By default, you can store only up to 64 startup hints in a shared cache. This count decrements by 1 each time a startup hint is stored. After the count reaches 0, no more hints can be added to the cache. You can use `-Xshareclasses:extraStartupHints=<number>` to adjust this count as needed. For example, `-Xshareclasses:extraStartupHints=0` prevents any new hints to be stored and `-Xshareclasses:extraStartupHints=10` allows 10 more new hints in addition to the default number of 64 startup hints.

You can use [`-Xshareclasses:printStats=startuphint`](#printstats-cache-utility) to check how many startup hints are already stored in the shared cache or `-Xshareclasses:printDetails` to check how many more hints can be stored in the cache.
Copy link
Member

@pshipton pshipton Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-Xshareclasses:printDetails isn't documented. If we are going to mention and recommend it, it should be documented.

The one line help for this options prints print detailed cache statistics. The output is similar to -Xshareclasses:printStats but it includes a little more information such as is found in the javacore. It breaks down some of the categories into finer grained details. Such as, instead of "AOT bytes" which is a total, it shows AOT code bytes, AOT data bytes, AOT class hierarchy bytes, AOT thunk bytes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also document that the information is found on the line # Additional startup hints allowed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-Xshareclasses:printDetails isn't documented. If we are going to mention and recommend it, it should be documented.

The one line help for this options prints print detailed cache statistics. The output is similar to -Xshareclasses:printStats but it includes a little more information such as is found in the javacore. It breaks down some of the categories into finer grained details. Such as, instead of "AOT bytes" which is a total, it shows AOT code bytes, AOT data bytes, AOT class hierarchy bytes, AOT thunk bytes.

Thank you for this information, Peter. I was awaiting clarification regarding this option from Hang Shao (#1433 (comment)) along with the feedback. I will include this in the document.

Is this option also a cache utility like printAllStats and printStats?

@Sreekala-Gopakumar
Copy link
Contributor Author

Jenkins doc stage

@pshipton
Copy link
Member

Is this option also a cache utility like printAllStats and printStats?

Yes. It's quite similar to printStats, there is overlap, but with extra output.


: Displays detailed cache statistics. The output of this suboption is similar to the output of [`-Xshareclasses:printStats`](#printstats-cache-utility) but with additional information. For example, instead of "AOT bytes" which is a total, the output shows "AOT code bytes", "AOT data bytes", "AOT class hierarchy bytes", and "AOT thunk bytes".

: The detailed information is found on the line `# Additional startup hints allowed`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in the extraStartupHints section.

eclipse-openj9#1433

New parameter 'extraStartupHints` added to the -Xshareclasses topic. Incorporated feedback.

Closes eclipse-openj9#1433
Signed-off-by: Sreekala Gopakumar [email protected]
@Sreekala-Gopakumar
Copy link
Contributor Author

Jenkins doc stage

@Sreekala-Gopakumar
Copy link
Contributor Author

@pshipton - I have made the changes. Please check and confirm. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New CML option to ajust the extra number of startup hints that can be stored into the shared cache.
3 participants