-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New CML option to adjust storage of extra startup hints #1462
base: master
Are you sure you want to change the base?
New CML option to adjust storage of extra startup hints #1462
Conversation
Jenkins doc stage |
cbfb34c
to
47c1ebf
Compare
Jenkins doc stage |
47c1ebf
to
ef8fca3
Compare
Jenkins doc stage |
ef8fca3
to
7667af6
Compare
Jenkins doc stage |
@hangshao0 - I have updated the documents. Please check and confirm. Thanks! |
@pshipton Please take a look |
docs/xshareclasses.md
Outdated
|
||
: Adjusts the number of startup hints that can be stored in a shared cache. By default, you can store only up to 64 startup hints in a shared cache. This count decrements by 1 each time a startup hint is stored. After the count reaches 0, no more hints can be added to the cache. You can use `-Xshareclasses:extraStartupHints=<number>` to adjust this count as needed. For example, `-Xshareclasses:extraStartupHints=0` prevents any new hints to be stored and `-Xshareclasses:extraStartupHints=10` allows 10 more new hints in addition to the default number of 64 startup hints. | ||
|
||
You can use [`-Xshareclasses:printStats=startuphint`](#printstats-cache-utility) to check how many startup hints are already stored in the shared cache or `-Xshareclasses:printDetails` to check how many more hints can be stored in the cache. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-Xshareclasses:printDetails isn't documented. If we are going to mention and recommend it, it should be documented.
The one line help for this options prints print detailed cache statistics
. The output is similar to -Xshareclasses:printStats
but it includes a little more information such as is found in the javacore. It breaks down some of the categories into finer grained details. Such as, instead of "AOT bytes" which is a total, it shows AOT code bytes, AOT data bytes, AOT class hierarchy bytes, AOT thunk bytes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also document that the information is found on the line # Additional startup hints allowed
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-Xshareclasses:printDetails isn't documented. If we are going to mention and recommend it, it should be documented.
The one line help for this options prints
print detailed cache statistics
. The output is similar to-Xshareclasses:printStats
but it includes a little more information such as is found in the javacore. It breaks down some of the categories into finer grained details. Such as, instead of "AOT bytes" which is a total, it shows AOT code bytes, AOT data bytes, AOT class hierarchy bytes, AOT thunk bytes.
Thank you for this information, Peter. I was awaiting clarification regarding this option from Hang Shao (#1433 (comment)) along with the feedback. I will include this in the document.
Is this option also a cache utility like printAllStats
and printStats
?
7667af6
to
e6850e7
Compare
Jenkins doc stage |
Yes. It's quite similar to printStats, there is overlap, but with extra output. |
docs/xshareclasses.md
Outdated
|
||
: Displays detailed cache statistics. The output of this suboption is similar to the output of [`-Xshareclasses:printStats`](#printstats-cache-utility) but with additional information. For example, instead of "AOT bytes" which is a total, the output shows "AOT code bytes", "AOT data bytes", "AOT class hierarchy bytes", and "AOT thunk bytes". | ||
|
||
: The detailed information is found on the line `# Additional startup hints allowed`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be in the extraStartupHints section.
eclipse-openj9#1433 New parameter 'extraStartupHints` added to the -Xshareclasses topic. Incorporated feedback. Closes eclipse-openj9#1433 Signed-off-by: Sreekala Gopakumar [email protected]
e6850e7
to
bd3cdd8
Compare
Jenkins doc stage |
@pshipton - I have made the changes. Please check and confirm. Thanks! |
#1433
New parameter 'extraStartupHints` added to the -Xshareclasses topic.
Closes #1433
Signed-off-by: Sreekala Gopakumar [email protected]