Separate tests that rely on SecurityManager (JLM_Tests) #14562
Conversation
|
|
EricYangIBM
force-pushed
the
sm_JLM_Tests
branch
from
5fb0867 to
6daa881
Compare
test/functional/JLM_Tests/build.xml
Outdated
| <compilerarg line='${addExports} ${TestUtilitiesExports}' /> | ||
| <!-- exclude tests that depend on SecurityManager --> | ||
| <exclude name="org/openj9/test/java/lang/management/TestSharedClassMemoryMXBean.java" /> | ||
| <exclude name="org/openj9/test/java/lang/management/TestRegression.java" /> |
There was a problem hiding this comment.
These two tests are still valuable if the security manager related APIs are separated, pls create two new classes w/o APIs to be removed.
| bean.setMaxHeapSize(size + 1024); | ||
| if (size + 1024 != bean.getMaxHeapSize()) { | ||
| throw new RuntimeException("not equal"); | ||
| } |
There was a problem hiding this comment.
Is this a duplicated sub-test somewhere, otherwise, pls keep original version, and create one w/o System.setSecurityManager(new SecurityManager()).
There was a problem hiding this comment.
I don't think this class is used at all
|
A separated |
|
I don't think a new testng file is needed here since I didn't add any java test files to the existing testng. Jdk19 will not fail to find the new compilation-ignored |
|
jenkins test sanity alinux64 jdk18,jdknext |
|
Pls add the _SM files into the testng.xml comment for the excluded tests, so if anyone fixes the tests they will realize these files exist. |
SecurityManager will be removed in a future jdk. Separate tests that rely on it so that they can be easily disabled in the future. Issue: eclipse-openj9#14412 Signed-off-by: Eric Yang <[email protected]>
EricYangIBM
force-pushed
the
sm_JLM_Tests
branch
from
ba12a31 to
56f845e
Compare
|
@llxia ping |
|
sorry, this slipped under my radar |
|
jenkins test sanity alinux64 jdk18,jdknext |
SecurityManager will be removed in a future jdk. Separate tests that
rely on it so that they can be easily disabled in the future.
Issue: #14412
Signed-off-by: Eric Yang [email protected]