Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AArch64: Enable SymbolValidationManager #15121

Closed
wants to merge 1 commit into from

Conversation

knn-k
Copy link
Contributor

@knn-k knn-k commented May 26, 2022

This commit enables SymbolValidationManager on AArch64.

Signed-off-by: KONNO Kazuhiro [email protected]

This commit enables SymbolValidationManager on AArch64.

Signed-off-by: KONNO Kazuhiro <[email protected]>
@knn-k
Copy link
Contributor Author

knn-k commented May 26, 2022

Jenkins test sanity.functional,extended.functional,sanity.system amac,alinux64 jdk11

@knn-k
Copy link
Contributor Author

knn-k commented May 26, 2022

I see failures with TestJlmRemote* in sanity.system on macOS. They are SEGVs in resolveStaticSplitMethodRef and resolveSpecialSplitMethodRef.

@dsouzai
Copy link
Contributor

dsouzai commented May 26, 2022

Enabling the SVM results in us executing more code paths under a relocatable compilation than before. This is because we no longer have to pretend that things are unresolved. However, the consequence of this is that there may be additional relocation records needed (e.g. resolved direct call snippet). #3028 goes over a few of the things that have be taken into account before the SVM can be enabled on a platform.

As such, I think specifically for #15059, the solution should be what @jdmpapin suggested, namely setting TR_DisableKnownObjectTable if we're doing a relocatable compile. Enabling the SVM is a useful effort but I believe it's going to require some vetting first.

@knn-k
Copy link
Contributor Author

knn-k commented May 30, 2022

Issue #15059 has been fixed by PR #15131 following the suggestion above.
I will revisit this PR sometime later for enabling SVM on AArch64.

@knn-k
Copy link
Contributor Author

knn-k commented Oct 19, 2022

I will not be working on this one soon. Closing.

@knn-k knn-k closed this Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants