Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SCC to be overridden during relocation #18878

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

cjjdespres
Copy link
Contributor

@cjjdespres cjjdespres commented Feb 1, 2024

An alternate SCC frontend may now be passed to the relocation runtime, which will be used for the duration of relocation. This isn't directly useful, but #18301 will need this to override the shared class cache interface used during relocation.

An alternate SCC frontend may now be passed to the relocation runtime,
which will be used for the duration of relocation.

Signed-off-by: Christian Despres <[email protected]>
@cjjdespres cjjdespres requested a review from dsouzai as a code owner February 1, 2024 20:27
@cjjdespres
Copy link
Contributor Author

Attn @mpirvu.

@mpirvu mpirvu self-assigned this Feb 2, 2024
Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look ok. The code assumes that during relocation we will always use the sharedCache coming from the frontend associated with a particular reloRuntime in play. If there are parts of the code that obtain the frontend or sharedCache differently than going reloRuntime-->fe-->sharedCache, things will start to break.

@mpirvu mpirvu added comp:jit:aot comp:jitserver Artifacts related to JIT-as-a-Service project labels Feb 2, 2024
@mpirvu
Copy link
Contributor

mpirvu commented Feb 2, 2024

jenkins test sanity plinuxjit,xlinuxjit,zlinuxjit,alinux64jit,zlinux jdk17

@mpirvu
Copy link
Contributor

mpirvu commented Feb 4, 2024

cmdLineTester_criu_nonPortableRestore_2 failed on zLinux_jit

@mpirvu
Copy link
Contributor

mpirvu commented Feb 4, 2024

jenkins test sanity zlinuxjit jdk17

@cjjdespres
Copy link
Contributor Author

Failure in sanity zlinuxjit jdk17 was:

11:36:26  Testing: Create CRIU checkpoint image and restore once - testMXBeanUpTime
11:36:26  Test start time: 2024/02/02 16:36:26 Coordinated Universal Time
11:36:26  Running command: bash /home/jenkins/workspace/Test_openjdk17_j9_sanity.functional_s390x_linux_jit_Personal_testList_0/aqa-tests/TKG/../../jvmtest/functional/cmdLineTests/criu/criuScript.sh /home/jenkins/workspace/Test_openjdk17_j9_sanity.functional_s390x_linux_jit_Personal_testList_0/aqa-tests/TKG/../../jvmtest/functional/cmdLineTests/criu /home/jenkins/workspace/Test_openjdk17_j9_sanity.functional_s390x_linux_jit_Personal_testList_0/jdkbinary/j2sdk-image/bin/java "-XX:+UseJITServer -XX:+JVMPortableRestoreMode  -Xtrace:print={j9jcl.533,j9vm.684-696,j9vm.699,j9vm.717-743} --add-exports java.base/openj9.internal.criu=ALL-UNNAMED" -Xdump:java+system+jit:events=throw+systhrow,filter=org/eclipse/openj9/criu/JVMCheckpointException org.openj9.criu.TimeChangeTest testMXBeanUpTime 1 false false
11:36:26  Time spent starting: 5 milliseconds
11:36:38  Time spent executing: 11123 milliseconds
11:36:38  Test result: FAILED
11:36:38  Output from test:
11:36:38   [OUT] start running script
11:36:38   [OUT] export GLIBC_TUNABLES=glibc.cpu.hwcaps=-XSAVEC,-XSAVE,-AVX2,-ERMS,-AVX,-AVX_Fast_Unaligned_Load
11:36:38   [OUT] export LD_BIND_NOT=on
11:36:38   [OUT] /home/jenkins/workspace/Test_openjdk17_j9_sanity.functional_s390x_linux_jit_Personal_testList_0/jdkbinary/j2sdk-image/bin/java -XX:+EnableCRIUSupport -XX:+UseJITServer -XX:+JVMPortableRestoreMode  -Xtrace:print={j9jcl.533,j9vm.684-696,j9vm.699,j9vm.717-743} --add-exports java.base/openj9.internal.criu=ALL-UNNAMED -cp /home/jenkins/workspace/Test_openjdk17_j9_sanity.functional_s390x_linux_jit_Personal_testList_0/aqa-tests/TKG/../../jvmtest/functional/cmdLineTests/criu/criu.jar -Xdump:java+system+jit:events=throw+systhrow,filter=org/eclipse/openj9/criu/JVMCheckpointException org.openj9.criu.TimeChangeTest testMXBeanUpTime
11:36:38   [OUT] Unhandled exception
11:36:38   [OUT] Type=Segmentation error vmState=0x00000000
11:36:38   [OUT] J9Generic_Signal_Number=00000018 Signal_Number=0000000b Error_Value=00000000 Signal_Code=00000001
11:36:38   [OUT] Handler1=000003FFA2E49720 Handler2=000003FFA2D31A10 InaccessibleAddress=0000000000000000
11:36:38   [OUT] gpr0=000003FF0400DD78 gpr1=000003FFA369E180 gpr2=000003FF0400DD78 gpr3=0000000000000000
11:36:38   [OUT] gpr4=0000000000000200 gpr5=000000000003B268 gpr6=000003FFA20382F8 gpr7=308345B4CF03EDF0
11:36:38   [OUT] gpr8=000003FF0400DD78 gpr9=000003FF00000001 gpr10=0000000000000000 gpr11=000003FF0400DCD0
11:36:38   [OUT] gpr12=000003FF04000CC8 gpr13=0000000001D76968 gpr14=000003FFA2010790 gpr15=000003FFA2BFC868
11:36:38   [OUT] psw=000003FFA369E192 mask=0705200180000000 fpc=00080000 bea=000003FFA200329C
11:36:38   [OUT] fpr0 42aabc0cbbb563ec (f: 3149227008.000000, d: 1.469748e+13)
11:36:38   [OUT] fpr1 000003ffa2bfb880 (f: 2730473472.000000, d: 2.172151e-311)
11:36:38   [OUT] fpr2 3e3ab2833493de2b (f: 882105920.000000, d: 6.215953e-09)
11:36:38   [OUT] fpr3 000003ff040037a0 (f: 67123104.000000, d: 2.170835e-311)
11:36:38   [OUT] fpr4 402f1fbda155c719 (f: 2706753280.000000, d: 1.556199e+01)
11:36:38   [OUT] fpr5 403d000000000000 (f: 0.000000, d: 2.900000e+01)
11:36:38   [OUT] fpr6 3ed6554dfe72a57a (f: 4268926208.000000, d: 5.324655e-06)
11:36:38   [OUT] fpr7 0000000000000000 (f: 0.000000, d: 0.000000e+00)
11:36:38   [OUT] fpr8 0000018d6aadb8d1 (f: 1789769984.000000, d: 8.433166e-312)
11:36:38   [OUT] fpr9 0000000000000000 (f: 0.000000, d: 0.000000e+00)
11:36:38   [OUT] fpr10 000003ffa2bbf000 (f: 2730225664.000000, d: 2.172151e-311)
11:36:38   [OUT] fpr11 0000000000000000 (f: 0.000000, d: 0.000000e+00)
11:36:38   [OUT] fpr12 00061068b698c926 (f: 3063466240.000000, d: 8.433166e-309)
11:36:38   [OUT] fpr13 000003ff8c4fbda8 (f: 2354036224.000000, d: 2.171965e-311)
11:36:38   [OUT] fpr14 000003ffea6f6f64 (f: 3933171456.000000, d: 2.172745e-311)
11:36:38   [OUT] fpr15 000003ff8c7291f8 (f: 2356318720.000000, d: 2.171966e-311)
11:36:38   [OUT] Module=/lib/s390x-linux-gnu/libc.so.6
11:36:38   [OUT] Module_base_address=000003FFA3600000
11:36:38   [OUT] Target=2_90_20240202_122 (Linux 5.4.0-144-generic)
11:36:38   [OUT] CPU=s390x (4 logical CPUs) (0x1f58fa000 RAM)
11:36:38   [OUT] ----------- Stack Backtrace -----------
11:36:38   [OUT]  (0x000003FFA369E192 [libc.so.6+0x9e192])
11:36:38   [OUT] getTrcBuf+0x370 (0x000003FFA2010790 [libj9trc29.so+0x10790])
11:36:38   [OUT] traceV+0xb54 (0x000003FFA2011A0C [libj9trc29.so+0x11a0c])
11:36:38   [OUT] doTracePoint+0xa34 (0x000003FFA2013484 [libj9trc29.so+0x13484])
11:36:38   [OUT] omrTrace+0x72 (0x000003FFA2013972 [libj9trc29.so+0x13972])
11:36:38   [OUT] attemptDynamicClassLoad+0x11c (0x000003FFA2E2CFDC [libj9vm29.so+0x2cfdc])
11:36:38   [OUT] internalFindClassInModule+0x12bc (0x000003FFA2E2EAF4 [libj9vm29.so+0x2eaf4])
11:36:38   [OUT] internalFindClassString+0x18e (0x000003FFA2E3125E [libj9vm29.so+0x3125e])
11:36:38   [OUT] _ZN36VM_CRIUBytecodeInterpreterCompressed3runEP10J9VMThread+0x133dc (0x000003FFA2FC065C [libj9vm29.so+0x1c065c])
11:36:38   [OUT] criuBytecodeLoopCompressed+0xee (0x000003FFA2FAD26E [libj9vm29.so+0x1ad26e])
11:36:38   [OUT] c_cInterpreter+0x64 (0x000003FFA3012CC4 [libj9vm29.so+0x212cc4])
11:36:38   [OUT] ---------------------------------------
11:36:38   [OUT] JVMDUMP039I Processing dump event "gpf", detail "" at 2024/02/02 16:36:26 - please wait.
11:36:38   [OUT] JVMDUMP032I JVM requested System dump using '/home/jenkins/workspace/Test_openjdk17_j9_sanity.functional_s390x_linux_jit_Personal_testList_0/aqa-tests/TKG/output_17068901013727/cmdLineTester_criu_nonPortableRestore_2/core.20240202.163626.712678.0001.dmp' in response to an event
11:36:38   [OUT] JVMDUMP010I System dump written to /home/jenkins/workspace/Test_openjdk17_j9_sanity.functional_s390x_linux_jit_Personal_testList_0/aqa-tests/TKG/output_17068901013727/cmdLineTester_criu_nonPortableRestore_2/core.20240202.163626.712678.0001.dmp
11:36:38   [OUT] JVMDUMP032I JVM requested Java dump using '/home/jenkins/workspace/Test_openjdk17_j9_sanity.functional_s390x_linux_jit_Personal_testList_0/aqa-tests/TKG/output_17068901013727/cmdLineTester_criu_nonPortableRestore_2/javacore.20240202.163626.712678.0002.txt' in response to an event
11:36:38   [OUT] JVMDUMP010I Java dump written to /home/jenkins/workspace/Test_openjdk17_j9_sanity.functional_s390x_linux_jit_Personal_testList_0/aqa-tests/TKG/output_17068901013727/cmdLineTester_criu_nonPortableRestore_2/javacore.20240202.163626.712678.0002.txt
11:36:38   [OUT] JVMDUMP032I JVM requested Snap dump using '/home/jenkins/workspace/Test_openjdk17_j9_sanity.functional_s390x_linux_jit_Personal_testList_0/aqa-tests/TKG/output_17068901013727/cmdLineTester_criu_nonPortableRestore_2/Snap.20240202.163626.712678.0003.trc' in response to an event
11:36:38   [OUT] JVMDUMP010I Snap dump written to /home/jenkins/workspace/Test_openjdk17_j9_sanity.functional_s390x_linux_jit_Personal_testList_0/aqa-tests/TKG/output_17068901013727/cmdLineTester_criu_nonPortableRestore_2/Snap.20240202.163626.712678.0003.trc
11:36:38   [OUT] JVMDUMP032I JVM requested JIT dump using '/home/jenkins/workspace/Test_openjdk17_j9_sanity.functional_s390x_linux_jit_Personal_testList_0/aqa-tests/TKG/output_17068901013727/cmdLineTester_criu_nonPortableRestore_2/jitdump.20240202.163626.712678.0004.dmp' in response to an event
11:36:38   [OUT] JVMDUMP051I JIT dump occurred in 'Attach API initializer' thread 0x0000000001D76900
11:36:38   [OUT] JVMDUMP010I JIT dump written to /home/jenkins/workspace/Test_openjdk17_j9_sanity.functional_s390x_linux_jit_Personal_testList_0/aqa-tests/TKG/output_17068901013727/cmdLineTester_criu_nonPortableRestore_2/jitdump.20240202.163626.712678.0004.dmp
11:36:38   [OUT] JVMDUMP013I Processed dump event "gpf", detail "".
11:36:38   [OUT] Removed test output files
11:36:38   [OUT] finished script
11:36:38   [ERR] cat: criuOutput: No such file or directory
11:36:38  >> Success condition was not found: [Output match: Killed]
11:36:38  >> Success condition was not found: [Output match: PASSED: testMXBeanUpTime()]
11:36:38  >> Failure condition was not found: [Output match: CRIU is not enabled]
11:36:38  >> Failure condition was not found: [Output match: Operation not permitted]
11:36:38  >> Failure condition was not found: [Output match: FAILED: testMXBeanUpTime()]
11:36:38  >> Success condition was not found: [Output match: Thread pid mismatch]
11:36:38  >> Success condition was not found: [Output match: do not match expected]
11:36:38  >> Success condition was not found: [Output match: Unable to create a thread:]
11:36:38  >> Failure condition was not found: [Output match: Could not dump the JVM processes, err=-70]
11:36:38  >> Failure condition was not found: [Output match: User requested Java dump using]

This might be the same kind of failure as #18839 (comment) (which I haven't seen before). The only issue with this test I can see is #18670, but it doesn't seem like the same type of failure.

@mpirvu
Copy link
Contributor

mpirvu commented Feb 5, 2024

jenkins test sanity zlinuxjit jdk17

@mpirvu
Copy link
Contributor

mpirvu commented Feb 6, 2024

Tests have passed, hence merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:jit:aot comp:jitserver Artifacts related to JIT-as-a-Service project
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants