[FFI/Jtreg_JDK22] Change the value of the heap address identifier #19002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fix has been verified in FFI related test suites in OpenJ9/Jtreg. |
|
Reviewer: @TobiAjila |
ChengJin01
added
project:panama
pshipton
reviewed
Feb 22, 2024
jcl/src/java.base/share/classes/openj9/internal/foreign/abi/InternalDowncallHandler.java
Outdated
Show resolved
Hide resolved
ChengJin01
force-pushed
the
ffi_jtreg_fix_downcall_heap_address_id_jdk22
branch
2 times, most recently
from
5d52c38 to
507c6f6
Compare
pshipton
approved these changes
Feb 23, 2024
|
jenkins test sanity.openjdk amac jdk22 |
tajila
approved these changes
Feb 23, 2024
keithc-ca
reviewed
Feb 23, 2024
ChengJin01
force-pushed
the
ffi_jtreg_fix_downcall_heap_address_id_jdk22
branch
2 times, most recently
from
0273447 to
1fa4d45
Compare
The tiny changes modify the constant used to identify the heap address in downcall to avoid any potential conflict with the address value passed to downcall. Fixes: eclipse-openj9#18999 Signed-off-by: ChengJin01 <[email protected]>
ChengJin01
force-pushed
the
ffi_jtreg_fix_downcall_heap_address_id_jdk22
branch
from
1fa4d45 to
3eff02b
Compare
|
For the record, the build that was underway is https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/5127. |
|
Just an unrelated known failure in the PR testing. Grinder testing java/foreign/TestAddressDereference.java |
|
Pls create the PR to unexclude the test. |
keithc-ca
approved these changes
Feb 23, 2024
ChengJin01
pushed a commit
to ChengJin01/aqa-tests
that referenced
this pull request
Feb 23, 2024
The changes enable the heap related test suites in JDK22+ given the problems with the tests are resolved via: [1] eclipse-openj9/openj9#18930 [2] eclipse-openj9/openj9#19002 Signed-off-by: ChengJin01 <[email protected]>
PR is created at adoptium/aqa-tests#5093. |
|
jenkins compile amac jdk22 |
llxia
pushed a commit
to adoptium/aqa-tests
that referenced
this pull request
Feb 23, 2024
The changes enable the heap related test suites in JDK22+ given the problems with the tests are resolved via: [1] eclipse-openj9/openj9#18930 [2] eclipse-openj9/openj9#19002 Signed-off-by: ChengJin01 <[email protected]>
This was referenced Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tiny changes modify the constant used to
identify the heap address in downcall to avoid
any potential conflict with the address value
passed to downcall.
Fixes: #18999
Signed-off-by: ChengJin01 [email protected]