Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conditional linking of libraries #20799

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

midronij
Copy link
Contributor

If a library is needed by any compiler, it should be used for all. Thus, this contribution removes the AIX && OPENXL condition that is used to add several extra libraries to j9vrb.

@midronij
Copy link
Contributor Author

@dsouzai here's the change removing the conditions from the list of linked libraries. It shouldn't depend on either of the other OpenXL PRs (#20690 and eclipse-omr/omr#7561).

@jdmpapin jdmpapin self-assigned this Dec 13, 2024
@jdmpapin
Copy link
Contributor

jdmpapin commented Dec 13, 2024

Skipping z/OS and Windows because there aren't any build machines up for those platforms

Jenkins build aarch64,aix,amac,arm,plinux,osx,riscv,x32linux,xlinux,zlinux

@jdmpapin
Copy link
Contributor

jdmpapin commented Dec 14, 2024

Jenkins build aarch64,aix,amac,arm,plinux,osx,riscv,x32linux,xlinux,zlinux

1 similar comment
@jdmpapin
Copy link
Contributor

jdmpapin commented Dec 16, 2024

Jenkins build aarch64,aix,amac,arm,plinux,osx,riscv,x32linux,xlinux,zlinux

@jdmpapin
Copy link
Contributor

Oh, I've been trying to use an OMR Jenkins command 🤦

Jenkins compile all jdk8,jdk21

@jdmpapin
Copy link
Contributor

jdmpapin commented Dec 16, 2024

Build failures on x86-64 Mac and Linux:

CMake Error: The inter-target dependency graph contains the following strongly connected component (cycle):
  "constgen" of type EXECUTABLE
    depends on "j9util" (weak)
    depends on "j9stackmap" (weak)
  "run_constgen" of type UTILITY
    depends on "constgen" (strong)
    depends on "constgen" (strong)
  "j9stackmap" of type STATIC_LIBRARY
    depends on "j9util" (weak)
  "j9util" of type STATIC_LIBRARY
    depends on "j9stackmap" (weak)
    depends on "run_constgen" (strong)
At least one of these targets is not a STATIC_LIBRARY.  Cyclic dependencies are allowed only among static libraries.
CMake Generate step failed.  Build files cannot be regenerated correctly.

@jdmpapin
Copy link
Contributor

It seems the windows builds will time out for lack of build machines, even though clicking on the label ci.role.build&&hw.arch.x86&&sw.os.windows seems at first sight to show two machines online. On closer inspection, both of those are "being launched"

@midronij, this change is causing a build error on Linux and Mac, but for some reason only on x86-64

And as with #20690, I can't tell about Windows or z/OS

@midronij
Copy link
Contributor Author

I'll try and run a build manually for Windows and z/OS as I did for #20690. And of course, I'll take a closer look at the x86-64 failures as well.

If a library is needed by any compiler, it should be used for all. Thus,
this contribution removes the AIX && OPENXL condition that is used to
add several extra libraries to j9vrb.

Signed-off-by: midronij <[email protected]>
@midronij midronij force-pushed the remove-lib-conditions branch from 5034820 to 30cffc7 Compare December 17, 2024 17:14
@midronij midronij force-pushed the remove-lib-conditions branch from 30cffc7 to a537a2e Compare December 17, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants