-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove conditional linking of libraries #20799
base: master
Are you sure you want to change the base?
Conversation
@dsouzai here's the change removing the conditions from the list of linked libraries. It shouldn't depend on either of the other OpenXL PRs (#20690 and eclipse-omr/omr#7561). |
Skipping z/OS and Windows because there aren't any build machines up for those platforms
|
|
1 similar comment
|
Oh, I've been trying to use an OMR Jenkins command 🤦 Jenkins compile all jdk8,jdk21 |
Build failures on x86-64 Mac and Linux:
|
It seems the windows builds will time out for lack of build machines, even though clicking on the label ci.role.build&&hw.arch.x86&&sw.os.windows seems at first sight to show two machines online. On closer inspection, both of those are "being launched" @midronij, this change is causing a build error on Linux and Mac, but for some reason only on x86-64 And as with #20690, I can't tell about Windows or z/OS |
I'll try and run a build manually for Windows and z/OS as I did for #20690. And of course, I'll take a closer look at the x86-64 failures as well. |
If a library is needed by any compiler, it should be used for all. Thus, this contribution removes the AIX && OPENXL condition that is used to add several extra libraries to j9vrb. Signed-off-by: midronij <[email protected]>
5034820
to
30cffc7
Compare
Signed-off-by: midronij <[email protected]>
30cffc7
to
a537a2e
Compare
If a library is needed by any compiler, it should be used for all. Thus, this contribution removes the
AIX && OPENXL
condition that is used to add several extra libraries to j9vrb.