Modify compile-time static field ref resolution #20847
Open
+19
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing code was introduced to improve the relocation success rate for AOT compilations that track dependencies, by attempting to resolve static field refs in jitGetClassOfFieldFromCP if they were not already resolved. This has introduced a regression in comp CPU for AOT stores, so the attempted field resolution has now been moved to the relevant record validation function to avoid this defect. Signed-off-by: Christian Despres <[email protected]>
|
Attn @mpirvu. This should address the issue mentioned in #20770 (comment). |
|
jenkins compile all jdk23 |
|
jenkins test sanity all jdk21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code was introduced to improve the relocation success rate for AOT compilations that track dependencies, by attempting to resolve static field refs in jitGetClassOfFieldFromCP if they were not already resolved. This has introduced a regression in comp CPU for AOT stores, so the attempted field resolution has now been moved to the relevant record validation function to avoid this defect.