Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not interrupt heap iteration if dataAddr is bad in DDR GC Check #20848

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

Do not interrupt heap iteration if dataAddr is bad in DDR GC Check #20848

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/gccheck/CheckEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,11 +228,11 @@ public int checkObjectHeap(J9ObjectPointer object, GCHeapRegionDescriptor region
CheckError error = new CheckError(object, _cycle, _currentCheck, elementName, result, _cycle.nextErrorCount());
_reporter.report(error);
/* There are some error cases would not prevent further iteration */
if (!(J9MODRON_GCCHK_RC_CLASS_IS_UNLOADED == result)) {
if ((J9MODRON_GCCHK_RC_CLASS_IS_UNLOADED == result) || (J9MODRON_GCCHK_RC_INVALID_INDEXABLE_DATA_ADDRESS == result)) {
return J9MODRON_SLOT_ITERATOR_OK;
} else {
_reporter.reportHeapWalkError(error, _lastHeapObject1, _lastHeapObject2, _lastHeapObject3);
return J9MODRON_SLOT_ITERATOR_UNRECOVERABLE_ERROR;
} else {
return J9MODRON_SLOT_ITERATOR_OK;
}
}

Expand Down