Abort ILGen for non supported features in AOT

[dsouzai]

Constant Dynamic, Method Handle Constant, and Method Type Constant
is not currently supported in AOT. Therefore, in this
PR, the compiler throws the appropriate exception in ILGen if this
condition is met. However, because all of these exceptions are a
TR::RecoverableILGenException, if the compiler is generating IL for an
inlined method, it will not abort the compile, but simply refuse to
inline that particular method.

Fixes #6011

[dsouzai]

jenkins test sanity.functional+aot xlinux jdk11

[dsouzai]

Yay the AOT test passed.

[dsouzai]

@andrewcraik @cathyzhyi could you please review?

[dsouzai]

@andrewcraik do we need to be also aborting an AOT compile in these conditions?

         else if (method()->isMethodHandleConstant(cpIndex))
            {
            loadSymbol(TR::aload, symRefTab()->findOrCreateMethodHandleSymbol(_methodSymbol, cpIndex));
            }
         else
            {
            TR_ASSERT(method()->isMethodTypeConstant(cpIndex), "Address-type CP entry %d must be class, string, methodHandle, or methodType", cpIndex);
            loadSymbol(TR::aload, symRefTab()->findOrCreateMethodTypeSymbol(_methodSymbol, cpIndex));
            }

[cathyzhyi]

The change looks good to me.

[andrewcraik]

@dsouzai I think the answer to your question on constant handles is yes - those constants could change in a new run.

[dsouzai]

@andrewcraik @cathyzhyi PR is ready for full review now.

[andrewcraik]

The aborts for the 292 handles are conservative - I am fine with doing it as discussed above, but there should be an issue to track disabling the code that would fold these so that we just leave them as loads. They would need a relocation to load them from the constant pool, but assuming we did that then it should work, just the scope of optimization will be limited because we cannot treat them as constant.

[dsouzai]

@andrewcraik opened #9106 to track this (and also added it to #2921).

[dsouzai]

jenkins test sanity.functional all jdk11

[dsouzai]

@andrewcraik all tests passed, do you mind merging if everything looks good to you?