Correctly update location attributes in Target Editor

These were completely ignored before
eclipse-pde · Apr 26, 2024 · d2ef4a6 · d2ef4a6
1 parent 00c9caf
commit d2ef4a6
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/target/TargetDefinition.java b/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/target/TargetDefinition.java
@@ -1325,6 +1325,11 @@ private void updateIUContainerElements(Element containersElement, List<Element>
 			}
 		}
 
+		// Use a mock comparator, we only want to use the
+		// "elementAttributesComparator" also used in updateElements
+		TargetDefinitionDocumentTools.updateElements(containersElement, oldContainers, newContainers,
+				(Element e1, Element e2) -> 0);
+
 		for (Entry<String, List<Element>> entry : oldContainersByRepo.entrySet()) {
 			entry.getValue().forEach(TargetDefinitionDocumentTools::removeChildAndWhitespace);
 		}