-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check getBundle returns non-null after PDE Manifest-editor opened. #1377
Check getBundle returns non-null after PDE Manifest-editor opened. #1377
Conversation
Now, legal agreement check passed, @HannesWell , @laeubi , @alshamams, please do review this PR. |
ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin/GeneralInfoSection.java
Outdated
Show resolved
Hide resolved
Thank you @peddaiahjuturu, the change looks good. But please squash your second commit into your first so that we have a single commit for this PR.
Then you can just force-push to this branch (no need to create a new PR). |
46db1ca
to
70bc75c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But please squash your second commit into your first so that we have a single commit for this PR.
I just did this for you so that we can submit this and have it for Milestone 3 for the upcoming release.
Thank you @HannesWell. Yesterday was national holiday here, i couldn`t login. |
i can delete this branch right? and, we can also enable GitHub setting for automatic branch deletion on PR merge right? |
Yes you can.
IIRC there is an option for that. I can check it. But I'm not sure if everybody want's that. |
It’s a setting on one’s own fork. |
Yes, i can do this on fork @merks . |
Bug details found here #1374
(Regression introduced by #949 and reported in #864)
After opening MANIFEST.MF file in PDE Manifest-editor and delete the project, ll get NPE.
Fixes #1374