Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing case in Bug528706CompletionWithMultilineTagsTest #1431

Merged

Conversation

HannesWell
Copy link
Member

@HannesWell HannesWell commented Oct 3, 2024

Is probably failing due to the update of the supported architectures list in eclipse-platform/eclipse.platform#1576.

And simplify AbstractTargetEditorTest.

@HannesWell
Copy link
Member Author

But I have to check if the test still makes sense with only one option available.

@eclipse-pde-bot
Copy link
Contributor

eclipse-pde-bot commented Oct 3, 2024

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ui/org.eclipse.pde.genericeditor.extension.tests/META-INF/MANIFEST.MF
ui/org.eclipse.pde.genericeditor.extension.tests/pom.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 4a88705c4e2120f15f6b647ca18da003f5894c6c Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <[email protected]>
Date: Thu, 3 Oct 2024 17:00:12 +0000
Subject: [PATCH] Version bump(s) for 4.34 stream


diff --git a/ui/org.eclipse.pde.genericeditor.extension.tests/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.genericeditor.extension.tests/META-INF/MANIFEST.MF
index a9d00f039a..7ff765d764 100644
--- a/ui/org.eclipse.pde.genericeditor.extension.tests/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.genericeditor.extension.tests/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: Tests for Generic Target Platform Editor
 Bundle-SymbolicName: org.eclipse.pde.genericeditor.extension.tests
-Bundle-Version: 1.2.400.qualifier
+Bundle-Version: 1.2.500.qualifier
 Bundle-Vendor: Eclipse.org
 Bundle-RequiredExecutionEnvironment: JavaSE-17
 Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)",
diff --git a/ui/org.eclipse.pde.genericeditor.extension.tests/pom.xml b/ui/org.eclipse.pde.genericeditor.extension.tests/pom.xml
index 3c2a92b549..07c4d6b602 100644
--- a/ui/org.eclipse.pde.genericeditor.extension.tests/pom.xml
+++ b/ui/org.eclipse.pde.genericeditor.extension.tests/pom.xml
@@ -18,7 +18,7 @@
     <relativePath>../../</relativePath>
   </parent>
   <artifactId>org.eclipse.pde.genericeditor.extension.tests</artifactId>
-  <version>1.2.400-SNAPSHOT</version>
+  <version>1.2.500-SNAPSHOT</version>
   <packaging>eclipse-test-plugin</packaging>
 
   <properties>
-- 
2.46.1

Further information are available in Common Build Issues - Missing version increments.

@HannesWell
Copy link
Member Author

/request-license-review

Copy link

github-actions bot commented Oct 3, 2024

/request-license-review

License review requests:

After all reviews have concluded, re-run the license-vetting check from the Github Actions web-interface to update its status.

Workflow run (with attached summary files):
https://github.com/eclipse-pde/eclipse.pde/actions/runs/11166088857

Adjust it to the available/known architectures since the update in
eclipse-platform/eclipse.platform#1576

And simplify AbstractTargetEditorTest.
@HannesWell HannesWell force-pushed the fix-failing-multiline_test branch from c7bbb51 to e4fee78 Compare October 3, 2024 16:53
Copy link

github-actions bot commented Oct 3, 2024

Test Results

   285 files  ±0     285 suites  ±0   56m 36s ⏱️ + 5m 52s
 3 581 tests ±0   3 505 ✅ +1   76 💤 ±0  0 ❌  - 1 
10 935 runs  ±0  10 704 ✅ +3  231 💤 ±0  0 ❌  - 3 

Results for commit 92e97d3. ± Comparison against base commit 151075f.

@HannesWell HannesWell merged commit 8bb1847 into eclipse-pde:master Oct 3, 2024
14 of 18 checks passed
@HannesWell HannesWell deleted the fix-failing-multiline_test branch October 3, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants