improve ClasspathUtilCore.getSourceAnnotation() performance #13 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get rid of some File.isFile() I/O where it is impossible that such file exists anyway: "file.jar/src.zip" "directory/absoulteFileName" In my usecase it reduces getSourceAnnotation() from 3sec to 1.2sec Signed-off-by: Joerg Kubitz <[email protected]>
|
@EclipseNewb are you the new @jukzi? |
|
Is M1 done? I didn't see a note that master is open for merge. |
|
Ups, I saw the go from all components in eclipse-platform/eclipse.platform.releng.aggregator#198 and assume that we released. But I also do not see the note. I assume we will not see a rebuild, so hopefully this does not need a revert. |
|
@vogella yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of some File.isFile() I/O where it is impossible that such file
exists anyway:
"file.jar/src.zip"
"directory/absoulteFileName"
In my usecase it reduces getSourceAnnotation() from 3sec to 1.2sec