Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve syntax highlighting colors for dark theme in MANIFEST.MF #1504

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve syntax highlighting colors for dark theme in MANIFEST.MF #1504

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ui/org.eclipse.pde.ui/css/e4-dark_pde_prefstyle.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ IEclipsePreferences#org-eclipse-pde-ui:org-eclipse-pde-ui {
'editor.color.header_assignment=103,207,241'
'editor.color.header_assignment_bold=true'
'editor.color.header_attributes=140,210,20'
'editor.color.header_key=221,40,103'
'editor.color.header_key_bold=true'
'editor.color.header_osgi=38,139,210'
'editor.color.header_key=18,144,195'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you are changing from red-ish to blue-ish?

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BeckerWdf Tbh I changed it during testing and later I forgot about it as I did not find a key in the manifest which uses it. Are you aware of such a key? I can change it back for this key if desired just to be save.

'editor.color.header_key_bold=false'
'editor.color.header_osgi=18,144,195'
'editor.color.header_value=23,198,163'
'editor.color.header_value_italic=true'
'editor.color.instr=221,40,103'
Expand Down
Loading