Imported packages showing version of matching packages #1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nburnwal09
force-pushed
the
importPkgVersionMatch_fix
branch
from
00cdf58 to
6e0ab00
Compare
|
@nburnwal09 for example if you have two version of SLF4J API in your target platform you will get multiple providers for that bundle/package version. |
nburnwal09
force-pushed
the
importPkgVersionMatch_fix
branch
from
6e0ab00 to
0ab6d90
Compare
I have verified this. It's working. |
laeubi
reviewed
Dec 27, 2024
| @@ -61,16 +62,17 @@ public DependencyPropertiesDialog(boolean editable, ExportPackageObject object) | |||
|
|
|||
| public DependencyPropertiesDialog(boolean editable, boolean showReexport, boolean export, boolean optional, String version, boolean showOptional, boolean isImport, String pluginId) { | |||
| super(PDEPlugin.getActiveWorkbenchShell()); | |||
| isPlugin = showReexport; | |||
There was a problem hiding this comment.
If isPlugin equals fShowReexport it should not need a new field.
Beside this "fShowReexport" seem to indicate it is more about reexported packages?
laeubi
force-pushed
the
importPkgVersionMatch_fix
branch
from
0ab6d90 to
c8f78e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit fixes Properties dialog of Imported packages showing version of matching packages. Implemented similar to required plugin properties section
Fixes #1501
@laeubi
One questions here:-