[win32] Refactor toolbar dpi callback #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoch-yatta
changed the title
akoch-yatta
force-pushed
the
refactor-toolbar-dpi-callback
branch
from
4e266f6
to
5104b44
Compare
akoch-yatta
force-pushed
the
refactor-toolbar-dpi-callback
branch
from
5104b44
to
530dc79
Compare
HeikoKlare
reviewed
Jul 26, 2024
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/internal/ImageList.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/internal/ImageList.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/internal/ImageList.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/internal/ImageList.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/ToolBar.java
Outdated
Show resolved
Hide resolved
akoch-yatta
force-pushed
the
refactor-toolbar-dpi-callback
branch
5 times, most recently
from
c3ea35b
to
09f2eb6
Compare
HeikoKlare
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
The change looks sound to me. I've also tested it (in combination with akoch-yatta/eclipse.platform.ui@384e390 to properly see effects on the main toolbar) and found it working fine.
@fedejeanne maybe you could also have a look since parts of the change slightly affect the behavior also when using existing HiDPI support, so it would be good to have an additional review.
This commit adds a method to receive handles for scaled variants of an ImageList for the specified zoom. All calls to the handle of an ImageList is replaced by the added method. Contributes to eclipse-platform#62 and eclipse-platform#131.
akoch-yatta
force-pushed
the
refactor-toolbar-dpi-callback
branch
from
09f2eb6
to
577b77c
Compare
fedejeanne
approved these changes
Jul 29, 2024
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/internal/ImageList.java
Outdated
Show resolved
Hide resolved
This commit refactors the callback use for ToolBar and ToolItem after a DPI change in the win32 implementation. It makes use of the scalable ImageList to reuse the existing items in the toolbar and only resets the ImageList with a correctly scaled one. Due to the limitations of the win32 implementation all items must be removed and re-added via the win32-API to make shrinking of toolbars possible. Additionally, the commit removes the now unused callback in ToolItem Contributes to eclipse-platform#62 and eclipse-platform#131.
akoch-yatta
force-pushed
the
refactor-toolbar-dpi-callback
branch
from
577b77c
to
ee0b8d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly is targeted on refactoring the existing callback for ToolBar and ToolItem after a DPI change in the win32 implementation.
To achieve that a method to scale an ImageList was added. Scaled variants of an image list are saved and reused similar to the other Resources.
The refactoring uses the scalable ImageLists to reuse the existing toolbar items and only resets the ImageList with a correctly scaled one. Due to the limitations of the win32 implementation all items must be removed and re-added via the win32-API to make shrinking of toolbars possible. Additionally, the commit removes the now unused callback in ToolItem.
All calls to the ImageList handle are replaced to use the added method.