Replace DPIUtil.get(Native)DeviceZoom for win32 #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amartya4256
force-pushed
the
replace_getDeviceZoom
branch
from
6e35962
to
818477e
Compare
HeikoKlare
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
The changes look sound.
@akoch-yatta are the changes also okay from your side?
Looks good to me as well |
This commit replaces DPIUtil.get(Native)DeviceZoom calls for win32 and uses the zoom information available within the controls. contributes to eclipse-platform#62 and eclipse-platform#127
HeikoKlare
force-pushed
the
replace_getDeviceZoom
branch
from
818477e
to
a26032d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have the zoom level information avaialble for the element, we can use the right zoom information instead of DPIUtil.get(Native)DeviceZoom method calls since this information might not always be right.