Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non system cursors adaption to DPI scale changes #1603

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ShahzaibIbrahim
Copy link
Contributor

Creating a map to provide different handle w.r.t the current zoom of the display. The method win32_getHandle provides the appropriate handle for the scaled image as per requested by the client.

HOW TO TEST

  • Run the Snippet92 (Image) or Snippet119 (Icon) with the following VM Arguments
-Dswt.autoScale=quarter
-Dswt.autoScale.updateOnRuntime=true
  • Run the example
  • Move the mouse pointer to the window
  • See if the mouse pointer is scaled to the current monitor zoom level.
  • Now move the window to another monitor with different zoom level (i.e. 200%)
  • Move the mouse pointer to the window again
  • See if the pointer still scaled correctly according to 200% zoom level

Creating a map to provide different handle w.r.t the current zoom of the
display. The method win32_getHandle provides the appropriate handle for
the scaled image as per requested by the client.
Copy link
Contributor

github-actions bot commented Nov 20, 2024

Test Results

   483 files  ±0     483 suites  ±0   8m 53s ⏱️ - 3m 41s
 4 095 tests ±0   4 085 ✅ ±0   7 💤 ±0  3 ❌ ±0 
16 173 runs  ±0  16 080 ✅ ±0  90 💤 ±0  3 ❌ ±0 

For more details on these failures, see this check.

Results for commit 76837d1. ± Comparison against base commit e6588c2.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@fedejeanne fedejeanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test this, I only have some proposals regarding the coding style and JavaDoc.

I also have 2 questions regarding returning a handle of a cursor that is already disposed and about making the field handle private.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non system cursors are not adapted to DPI scale changes
2 participants