Deprecate TypedListener for removal to make it strongly internal later #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 483 files ±0 483 suites ±0 8m 57s ⏱️ -57s For more details on these failures, see this check. Results for commit ed4b5f3. ± Comparison against base commit 2cc00b7. ♻️ This comment has been updated with latest results. |
HannesWell
force-pushed
the
deprecate-TypedListener-for-removal
branch
from
e7dec2f
to
573aee0
Compare
HannesWell
force-pushed
the
deprecate-TypedListener-for-removal
branch
from
573aee0
to
ed4b5f3
Compare
|
It looks like there is no reference to this class in the Eclipse-SDK (anymore). So if there are no objections about continuing with this I plan to submit this tomorrow evening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class
TypedListeneris intended to be internal even if it's in a public package and because there were cases where it has to be used for custom widges it happened that it was still used. With the APIs introduced in #1112 there are better solutions using only public APIs for the cases it was still used.Together with #1615 this is the continuation of #1101 (comment) to deprecate
TypedListenerfor removal so that it can later be moved into an internal package to strengthen the statement that it's internal.Eclipse Nebula also does not use