Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search while you type... #78 #81

Closed
wants to merge 2 commits into from

Conversation

jukzi
Copy link
Contributor

@jukzi jukzi commented Aug 25, 2022

Adds a search filter to search result View after first search.
Press ENTER to get into the fine grained search Dialog.

Providers have to implement IResearchQuery

  • some multithreading hardening of the search which pop up under that
    heavy load.

Adds a search filter to search result View after first search.
Press ENTER to get into the fine grained search Dialog.

Providers have to implement IResearchQuery

+ some multithreading hardening of the search which pop up under that
heavy load.
@mickaelistria
Copy link
Contributor

I'm worried this proposal is very intrustive in the search API for something that seems more like a UI functionily mostly.
I'll get back to the ticket to discuss possible less intrusive alternatives and maybe looser coupling.

@jukzi
Copy link
Contributor Author

jukzi commented Aug 26, 2022

I'm worried this proposal is very intrustive in the search API for something that seems more like a UI functionily mostly.
I'll get back to the ticket to discuss possible less intrusive alternatives and maybe looser coupling.

I don't get that comment. the API is only extended and totally optional. you can't get cool feature without API.

@mickaelistria
Copy link
Contributor

Enabling this feature would require to adopt new API; I wish we can find a solution to eclipse-platform/eclipse.platform.ui#878 without new API.

@vogella
Copy link
Contributor

vogella commented Aug 26, 2022

I personally would love the functionality in the IDE. Thanks @jukzi for working on this. Once master opens I plan also to comment on the code (I did not yet look at it).

@laeubi
Copy link
Contributor

laeubi commented Jun 28, 2023

This repository was merged with https://github.com/eclipse-platform/eclipse.platform.ui if your pull-request is still relevant please rebase the code and push it to the new repository.

@laeubi laeubi closed this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants