File search: Reliable and fast cancel #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
split from eclipse-platform/eclipse.platform.ui#878 |
|
File search did not cancel it's worker jobs if the user canceled before the monitorUpdateJob was running (scheduling it is no guarantee that is already running). * monitor job is now incorporated into the search thread. * fixed expected number of files to scan * do not exit search thread before all workers finished. * cancel search if any of the workers canceled * forward cancel immediately (do not wait 100ms)
jukzi
force-pushed
the
cancelTextSearchVisitor
branch
from
7d18f0b to
498a40b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File search did not cancel it's worker jobs if the user canceled before
the monitorUpdateJob was running (scheduling it is no guarantee that is
already running).