Skip to content

Commit

Permalink
Revert "Store properties dialog bounds. (#1282)" fixes #1895
Browse files Browse the repository at this point in the history
This reverts commit 8abe1b1.

The PreferenceDialog has a custom size calculation that tries to adapt
to the current page. That contradicts using the the former size

#1895
  • Loading branch information
EcljpseB0T authored and jukzi committed Jun 6, 2024
1 parent 3ef39fa commit 1f3c3e1
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 13 deletions.
2 changes: 1 addition & 1 deletion bundles/org.eclipse.ui.ide/META-INF/MANIFEST.MF
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %Plugin.name
Bundle-SymbolicName: org.eclipse.ui.ide; singleton:=true
Bundle-Version: 3.22.200.qualifier
Bundle-Version: 3.22.300.qualifier
Bundle-Activator: org.eclipse.ui.internal.ide.IDEWorkbenchPlugin
Bundle-ActivationPolicy: lazy
Bundle-Vendor: %Plugin.providerName
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@

import java.util.Iterator;
import org.eclipse.core.runtime.Adapters;
import org.eclipse.jface.dialogs.DialogSettings;
import org.eclipse.jface.dialogs.IDialogSettings;
import org.eclipse.jface.dialogs.MessageDialog;
import org.eclipse.jface.preference.IPreferenceNode;
import org.eclipse.jface.preference.PreferenceManager;
Expand All @@ -31,10 +29,8 @@
import org.eclipse.ui.PlatformUI;
import org.eclipse.ui.internal.IWorkbenchHelpContextIds;
import org.eclipse.ui.internal.WorkbenchMessages;
import org.eclipse.ui.internal.WorkbenchPlugin;
import org.eclipse.ui.model.IContributionService;
import org.eclipse.ui.model.IWorkbenchAdapter;
import org.osgi.framework.Bundle;

/**
* This dialog is created and shown when 'Properties' action is performed while
Expand Down Expand Up @@ -184,11 +180,4 @@ protected String getContributionType() {
return IContributionService.TYPE_PROPERTY;
}

@Override
protected IDialogSettings getDialogBoundsSettings() {
Bundle bundle = WorkbenchPlugin.getDefault().getBundle();
IDialogSettings settings = PlatformUI.getDialogSettingsProvider(bundle).getDialogSettings();
String name = getClass().getSimpleName() + ".dialogBounds"; //$NON-NLS-1$
return DialogSettings.getOrCreateSection(settings, name);
}
}
2 changes: 1 addition & 1 deletion bundles/org.eclipse.ui.workbench/META-INF/MANIFEST.MF
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %pluginName
Bundle-SymbolicName: org.eclipse.ui.workbench; singleton:=true
Bundle-Version: 3.132.0.qualifier
Bundle-Version: 3.132.100.qualifier
Bundle-Activator: org.eclipse.ui.internal.WorkbenchPlugin
Bundle-ActivationPolicy: lazy
Bundle-Vendor: %providerName
Expand Down

0 comments on commit 1f3c3e1

Please sign in to comment.