Skip to content

Commit

Permalink
Remove the help icon from the restart Eclipse due to theme changes
Browse files Browse the repository at this point in the history
Operating system Ui guidelines do not recommend the usage of the help
icon in a dialog. For example check the screenshots in the Windows
guidelines for dialogs.

Operating System UI Guidelines

Windows UI guidence
https://docs.microsoft.com/en-us/windows/apps/design/controls/dialogs-and-flyouts/dialogs

Gnome UI guidence
https://developer.gnome.org/hig/patterns/feedback/dialogs.html

Mac UI guidence
https://developer.apple.com/design/human-interface-guidelines/components/presentation/alerts/
  • Loading branch information
vogella committed Jun 14, 2022
1 parent a0dd966 commit 355071e
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ public boolean performOk() {
*/
private void showRestartDialog() {
if (new MessageDialog(null, WorkbenchMessages.ThemeChangeWarningTitle, null,
WorkbenchMessages.ThemeChangeWarningText, MessageDialog.QUESTION, 2,
WorkbenchMessages.ThemeChangeWarningText, MessageDialog.NONE, 2,
WorkbenchMessages.Workbench_RestartButton, WorkbenchMessages.Workbench_DontRestartButton)
.open() == Window.OK) {
Display.getDefault().asyncExec(() -> PlatformUI.getWorkbench().restart());
Expand Down

0 comments on commit 355071e

Please sign in to comment.