FindReplaceLogic.updateTarget should call endSession on current target

eclipse-platform · Apr 24, 2024 · 669d80a · 669d80a
1 parent 3c86ecf
commit 669d80a
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/....ui.workbench.texteditor/src/org/eclipse/ui/internal/findandreplace/FindReplaceLogic.java b/....ui.workbench.texteditor/src/org/eclipse/ui/internal/findandreplace/FindReplaceLogic.java
@@ -588,12 +588,11 @@ public void updateTarget(IFindReplaceTarget newTarget, boolean canEditTarget) {
 		this.isTargetEditable = canEditTarget;
 
 		if (this.target != newTarget) {
-			if (newTarget != null && newTarget instanceof IFindReplaceTargetExtension)
-				((IFindReplaceTargetExtension) newTarget).endSession();
+			if (this.target instanceof IFindReplaceTargetExtension)
+				((IFindReplaceTargetExtension) this.target).endSession();
 
 			this.target = newTarget;
-			if (newTarget != null)
-				isTargetSupportingRegEx = newTarget instanceof IFindReplaceTargetExtension3;
+			isTargetSupportingRegEx = newTarget instanceof IFindReplaceTargetExtension3;
 
 			if (newTarget instanceof IFindReplaceTargetExtension) {
 				((IFindReplaceTargetExtension) newTarget).beginSession();