Find/Replace overlay: immediate replace after selected text #2011

The TextViewer implementation of IFindReplaceTargetExtension3.replaceSelection() does not perform
a replace operation if no preceeding find operation was called. To address this accepted
deviation from the interface's specification, this change forces the overlay to search for an initializing
word again so that the Editor can then later replace it if required.

fixes #2011

bundles/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/internal/findandreplace/overlay/FindReplaceOverlay.java

@@ -944,6 +944,7 @@ private void updateFromTargetSelection() {
 				selectionText = FindReplaceDocumentAdapter.escapeForRegExPattern(selectionText);
 			}
 			searchBar.setText(selectionText);
+			findReplaceLogic.findAndSelect(findReplaceLogic.getTarget().getSelection().x, searchBar.getText());
 		}
 		searchBar.setSelection(0, searchBar.getText().length());
 	}

tests/org.eclipse.ui.workbench.texteditor.tests/src/org/eclipse/ui/internal/findandreplace/FindReplaceUITest.java

@@ -353,6 +353,18 @@ public void testActivateDialogSelectionActive_withRegExOptionActivated() {
 		assertThat(fTextViewer.getDocument().get(), is("test ;"));
 	}
 
+	@Test
+	public void testReplaceIfSelectedOnStart() {
+		openTextViewer("abcdefg");
+		fTextViewer.setSelection(new TextSelection(2, 2));
+		initializeFindReplaceUIForTextViewer();
+
+		dialog.setReplaceText("aa");
+		dialog.performReplace();
+
+		assertThat(fTextViewer.getDocument().get(), is("abaaefg"));
+	}
+
 	protected AccessType getDialog() {
 		return dialog;
 	}