Replace/Find button skips every second occurrence #1540

basilevs · 2024-01-22T17:48:47Z

I verified I can reproduce this issue against latest Integration Build of Eclipse SDK

Steps to reproduce

From a fresh installation and clean workspace:

Create an "Untitled Text Document"
Enter following content:

testa!
testb!
testc!

Set the cursor to the start of the document
Hit Command+F
Fill "Find" field with (\w)!
Fill "Replace with" field with \1 !
Set checkbox "Regular expressions"
Hit Find button
Hit Replace/Find button

I expected:

testa !
testb!
testc!

But got:

testa!
testb !
testc!

Tested under this environment:

Ubuntu 22.04.3 LTS
Eclipse SDK: Version: 2024-03 (4.31) Build id: I20240121-1800

Community

I understand reporting an issue to this OSS project does not mandate anyone to fix it. Other contributors may consider the issue, or not, at their own convenience. The most efficient way to get it fixed is that I fix it myself and contribute it back as a good quality patch to the project.

The text was updated successfully, but these errors were encountered:

The replace functionality of the FindAndReplaceLogic checks whether the current selection fits to the current search string and otherwise performs a find operation first. To this end, it compares the text selection with the search string, even if regex search is used. In regex search mode, this check will usually fail and a find operation is performed even though a correct string is already selected. This results in the replacement of the next instead of the current match. With this change, the check for whether the currently selected string fits to the search string properly considers regex search mode. It also adds an according regression test. Fixes eclipse-platform#1540

HeikoKlare · 2024-01-22T19:07:35Z

Thanks for reporting, @basilevs! I've proposed a fix in #1541. I've successfully tested your scenario with the fix.

…pse-platform#1540 The replace functionality of the FindAndReplaceLogic checks whether the current selection fits to the current search string and otherwise performs a find operation first. To this end, it compares the text selection with the search string, even if regex search is used. In regex search mode, this check will usually fail and a find operation is performed even though a correct string is already selected. This results in the replacement of the next instead of the current match. With this change, the check for whether the currently selected string fits to the search string properly considers regex search mode. In consequence, all replace operations consider the current selection for replacement if fitting. It also adds an according regression tests. Fixes eclipse-platform#1540

…pse-platform#1540 The replace functionality of the FindAndReplaceLogic checks whether the current selection fits to the current search string and otherwise performs a find operation first. To this end, it compares the text selection with the search string, even if regex search is used. In regex search mode, this check will usually fail and a find operation is performed even though a correct string is already selected. This results in the replacement of the next instead of the current match. With this change, the check for whether the currently selected string fits to the search string properly considers regex search mode. In consequence, all replace operations consider the current selection for replacement if fitting. It also adds according regression tests. Fixes eclipse-platform#1540

The replace functionality of the FindAndReplaceLogic checks whether the current selection fits to the current search string and otherwise performs a find operation first. To this end, it compares the text selection with the search string, even if regex search is used. In regex search mode, this check will usually fail and a find operation is performed even though a correct string is already selected. This results in the replacement of the next instead of the current match. With this change, the check for whether the currently selected string fits to the search string properly considers regex search mode. In consequence, all replace operations consider the current selection for replacement if fitting. It also adds according regression tests. Fixes #1540

…pse-platform#1540 The replace functionality of the FindAndReplaceLogic checks whether the current selection fits to the current search string and otherwise performs a find operation first. To this end, it compares the text selection with the search string, even if regex search is used. In regex search mode, this check will usually fail and a find operation is performed even though a correct string is already selected. This results in the replacement of the next instead of the current match. With this change, the check for whether the currently selected string fits to the search string properly considers regex search mode. In consequence, all replace operations consider the current selection for replacement if fitting. It also adds according regression tests. Fixes eclipse-platform#1540

basilevs added the bug Something isn't working label Jan 22, 2024

basilevs mentioned this issue Jan 22, 2024

Proposal: modern and well-integrated Find/Replace #1090

Open

HeikoKlare mentioned this issue Jan 22, 2024

Fix replace behavior of FindReplaceLogic/Dialog for RegEx search #1540 #1541

Merged

HeikoKlare closed this as completed in #1541 Jan 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace/Find button skips every second occurrence #1540

Replace/Find button skips every second occurrence #1540

basilevs commented Jan 22, 2024 •

edited

Loading

HeikoKlare commented Jan 22, 2024

Replace/Find button skips every second occurrence #1540

Replace/Find button skips every second occurrence #1540

Comments

basilevs commented Jan 22, 2024 • edited Loading

Steps to reproduce

Tested under this environment:

Community

HeikoKlare commented Jan 22, 2024

basilevs commented Jan 22, 2024 •

edited

Loading