Fix replace behavior of FindReplaceLogic/Dialog for RegEx search #1540 #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Test Results 918 files ±0 918 suites ±0 47m 48s ⏱️ + 1m 17s For more details on these failures, see this check. Results for commit 3ebee11. ± Comparison against base commit 4b0353a. ♻️ This comment has been updated with latest results. |
HeikoKlare
force-pushed
the
issue-1540
branch
from
a3b8f42 to
451354a
Compare
HeikoKlare
changed the title
HeikoKlare
force-pushed
the
issue-1540
branch
6 times, most recently
from
127756b to
6a55549
Compare
…pse-platform#1540 The replace functionality of the FindAndReplaceLogic checks whether the current selection fits to the current search string and otherwise performs a find operation first. To this end, it compares the text selection with the search string, even if regex search is used. In regex search mode, this check will usually fail and a find operation is performed even though a correct string is already selected. This results in the replacement of the next instead of the current match. With this change, the check for whether the currently selected string fits to the search string properly considers regex search mode. In consequence, all replace operations consider the current selection for replacement if fitting. It also adds according regression tests. Fixes eclipse-platform#1540
HeikoKlare
force-pushed
the
issue-1540
branch
from
6a55549 to
3ebee11
Compare
|
Failing test is documented as random failure: #751 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The replace functionality of the
FindAndReplaceLogicchecks whether the current selection fits to the current search string and otherwise performs a find operation first. To this end, it compares the text selection with the search string, even if regex search is used. In regex search mode, this check will usually fail and a find operation is performed even though a correct string is already selected. This results in the replacement of the next instead of the current match.With this change, the check for whether the currently selected string fits to the search string properly considers regex search mode. In consequence, all replace operations consider the current selection for replacement if fitting. It also adds according regression tests.
Fixes #1540