[Win] Most tests in I20240213-1800 DNF waiting on "WindowsDefenderConfigurator" #1683
Comments
Only run the startup check if the running application is 'org.eclipse.ui.ide.workbench', which runs in a usual Eclipse IDE. Requiring this specific app-id prevents the start-up check and consequently a pop-up in test applications launched by PDE or Tycho for OSGi Junit tests or general console applications (that still have the 'o.e.ui.workbench' plugin installed) on Windows. Fixes eclipse-platform#1683
Only run the startup check if the running application is 'org.eclipse.ui.ide.workbench', which runs in a usual Eclipse IDE. Requiring this specific app-id prevents the start-up check and consequently a pop-up in test applications launched by PDE or Tycho for OSGi Junit tests or general console applications (that still have the 'o.e.ui.workbench' plugin installed) on Windows. Fixes eclipse-platform#1683
Only run the startup check if the running application is 'org.eclipse.ui.ide.workbench', which runs in a usual Eclipse IDE. Requiring this specific app-id prevents the start-up check and consequently a pop-up in test applications launched by PDE or Tycho for OSGi Junit tests or general console applications (that still have the 'o.e.ui.workbench' plugin installed) on Windows. Fixes #1683
|
Looks like it is hanging again... |
|
I'm really puzzled on this one. But in both cases Could it be that the the primary launched eclipse runs another secondary eclipse with the |
|
Thinking about it again, it is probably that with #1685 only the app defined in the product is considered, not an app defined on the CLI like it is the case here. |
|
I am not sure whether I can help here, as you probably already know everything I can contribute, so feel free to just ignore my comment. I see the following potential trace to starting a
|
|
@HannesWell I really think this should be just a preference (off by default), then it could be set for any EPP or custom product instead of some guess working. |
Consider also applications specified on the CLI via the '-application' argument when determining the actually running application. Otherwise always the application defined in the product definition is assumed. Fixes eclipse-platform#1683
|
Putting the code into a fragment might be a good alternative as well. |
I have now created #1686 to address that.
Thanks for that hint. I wasn't aware that even the test-apps can also call But lets see if #1686 is sufficient and if not I have to think about other tricks (e.g. checking if a
This would mean that every product based on Eclipse would have to enabled it explicitly, even those that define an 'extended' IDE that use the But even if it would be 'off' by default it would not solve the problem. Because as you said EPP would turn it on and the Eclipse SDK as well. But the I-build tests just use the Eclipse SDK and launch it from the CLI with the antRunner app specified. So we would be in the same situation. But of course I would also prefer a solution with less guessing, but the current one seems to be the best trade-off to make this new feature available where it could be helpful while avoiding unwanted pop-ups.
This would IMHO be an overkill and would also not solve the problem with the tests. On other platforms than Windows you will not notice anything about it anyways. |
Consider also applications specified on the CLI via the '-application' argument when determining the actually running application. Otherwise always the application defined in the product definition is assumed. Fixes #1683
|
Looks like #1686 really fixed the windows tests. Thanks everyone involved and for your patience. A side note: |
Regression from #1453.
Most of Windows test hang in https://download.eclipse.org/eclipse/downloads/drops4/I20240213-1800/testResults.php
See
That must be fixed for M3.
Thread dump:
The text was updated successfully, but these errors were encountered: