Suppress Windows Defender Autofix startup check in test-runtimes part 2 #1686
Conversation
Consider also applications specified on the CLI via the '-application' argument when determining the actually running application. Otherwise always the application defined in the product definition is assumed. Fixes eclipse-platform#1683
| private static String getRunningApplicationId() { | ||
| @SuppressWarnings("restriction") | ||
| String appId = System.getProperty(org.eclipse.core.internal.runtime.InternalPlatform.PROP_APPLICATION); | ||
| if (appId != null) { | ||
| return appId; | ||
| } | ||
| IProduct product = Platform.getProduct(); | ||
| return product != null ? product.getApplication() : null; | ||
| } | ||
|
|
There was a problem hiding this comment.
Reading the System-properties is effectively what's done in the proposed solution in #1453 (comment) (EnvironmentInfo only also considers a potential SecurityManager before reading the System-properties, but I assume that nobody is using SecurityManagers anymore).
It is set at startup in org.eclipse.equinox.internal.app.CommandLineArgs class.
On the long run it might be interesting to have something like this available as API, e.g. Platform.getApplication() similar to Platform.getProduct() since this might be of interest for others as well.
Test Results 612 files - 306 612 suites - 306 59m 18s ⏱️ - 10m 37s Results for commit 76f9f43. ± Comparison against base commit 42a4d8b. This pull request skips 5 tests. |
|
API tools failure in Linux-build seems unrelated. Submitting. |
|
@HannesWell : if you are ready, please trigger new IBuild, as we need Windows tests for M3 running and we also want have new build for eclipse-jdt/eclipse.jdt.core#2025. |
|
@iloveeclipse could you please start an I build, I'm not at my computer anymore. |
Consider also applications specified on the CLI via the '-application' argument when determining the actually running application. Otherwise always the application defined in the product definition is assumed.
Fixes #1683