VerifyError with unnamed pattern variable in instanceof

[srikanth-sankaran]

What it does

• Fixes [Patterns][Unnamed] VerifyError with unnamed pattern variable in instanceof  #2024

Author checklist

• I have thoroughly tested my changes
• The change is following the coding conventions
• I have signed the Eclipse Contributor Agreement (ECA)

[srikanth-sankaran]

@mpalat, @jarthana - This needs to be included for RC1 - this is a regression.

This is exposed by - not caused by - a recent commit #2016

Underlying defective change was introduced via commit b4875fc made for #1517 and merged on 2024-01-29 at 09:51:08

See #2024 (comment) for an explanation.

[mpalat]

+1
please go ahead and merge

[srikanth-sankaran]

Thanks for the review @mpalat ! Could this be picked up for M3 please ?

[mpalat]

@MohananRahul Could you please respin to include this for M3? this is a regression and fix is straightforward. Thanks!

[iloveeclipse]

@MohananRahul Could you please respin to include this for M3? this is a regression and fix is straightforward. Thanks!

Please don't do that yet, we are waiting for eclipse-platform/eclipse.platform.ui#1686

[iloveeclipse]

New build is triggered: https://ci.eclipse.org/releng/job/Builds/job/I-build-4.31/137/

[srikanth-sankaran]

New build is triggered: https://ci.eclipse.org/releng/job/Builds/job/I-build-4.31/137/

I have verified that this build

Eclipse SDK

Version: 2024-03 (4.31)
Build id: I20240215-0450

contains the fix. The program from #2024 (comment) compiles and runs fine in this build with no verify error.