Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JUnit tests in org.eclipse.jface.text.tests.contentassist are failing on Windows and Mac #890

Open
ktatavarthi opened this issue Jun 2, 2022 · 16 comments
Open

JUnit tests in org.eclipse.jface.text.tests.contentassist are failing on Windows and Mac #890

ktatavarthi opened this issue Jun 2, 2022 · 16 comments
Labels
help wanted Extra attention is needed test junit test related things

Comments

@ktatavarthi
Copy link
Member

This is a duplicate of Bug 571316 - JUnit tests in org.eclipse.jface.text.tests.contentassist are failing on Windows and Mac

I will close the bug in bugzilla and this bug will be tracked here.

The JFace text tests in org.eclipse.jface.text.tests.contentassist fail in the nightly build as below

Windows

  1. testCompleteActivationChar

Both Windows and Mac

  1. testSyncFailureNPE
@ktatavarthi ktatavarthi mentioned this issue Jun 2, 2022
Closed
@ktatavarthi
Copy link
Member Author

eclipse-platform/eclipse.platform.text#9 is a duplicate of this bug.

@ktatavarthi
Copy link
Member Author

The below test failed in the IBuild I20220601-1800 on Windows and Mac

Windows

  • org.eclipse.jface.text.tests.contentassist.AsyncContentAssistTest.testCompleteActivationChar
  • org.eclipse.jface.text.tests.contentassist.AsyncContentAssistTest.testSyncFailureNPE

Mac x86_64 and aarch64

  • org.eclipse.jface.text.tests.contentassist.AsyncContentAssistTest.testSyncFailureNPE

@ktatavarthi ktatavarthi mentioned this issue Jun 2, 2022
Closed
13 tasks
@ktatavarthi
Copy link
Member Author

The below tests failed in the IBuild I20220706-1800 on Windows

  • org.eclipse.jface.text.tests.contentassist.AsyncContentAssistTest.testCompleteActivationChar
  • org.eclipse.jface.text.tests.contentassist.AsyncContentAssistTest.testSyncFailureNPE

@ktatavarthi ktatavarthi mentioned this issue Jul 7, 2022
Closed
13 tasks
@ktatavarthi
Copy link
Member Author

The below tests failed in the IBuild I20220817-1800

On Windows

  • org.eclipse.jface.text.tests.contentassist.AsyncContentAssistTest.testCompleteActivationChar
  • org.eclipse.jface.text.tests.contentassist.AsyncContentAssistTest.testSyncFailureNPE

On Mac x86_64 and aarch64

  • org.eclipse.jface.text.tests.contentassist.AsyncContentAssistTest.testSyncFailureNPE

@ktatavarthi ktatavarthi mentioned this issue Aug 18, 2022
Closed
13 tasks
@ktatavarthi
Copy link
Member Author

The below tests failed in the IBuild I20220824-1800

On Windows

  • org.eclipse.jface.text.tests.contentassist.AsyncContentAssistTest.testCompleteActivationChar
  • org.eclipse.jface.text.tests.contentassist.AsyncContentAssistTest.testSyncFailureNPE

On Mac x86_64 and aarch64

  • org.eclipse.jface.text.tests.contentassist.AsyncContentAssistTest.testSyncFailureNPE

@ktatavarthi ktatavarthi mentioned this issue Aug 25, 2022
Closed
13 tasks
@ktatavarthi
Copy link
Member Author

The below tests failed in the IBuild I20220831-1800

On Windows

  • org.eclipse.jface.text.tests.contentassist.AsyncContentAssistTest.testCompleteActivationChar
  • org.eclipse.jface.text.tests.contentassist.AsyncContentAssistTest.testSyncFailureNPE

On MacM1

  • org.eclipse.jface.text.tests.contentassist.AsyncContentAssistTest.testSyncFailureNPE

@ktatavarthi ktatavarthi mentioned this issue Sep 1, 2022
Closed
13 tasks
@ktatavarthi
Copy link
Member Author

The below test failed in the IBuild I20220928-1800

On Windows

  • org.eclipse.jface.text.tests.contentassist.AsyncContentAssistTest.testCompleteActivationChar

@ktatavarthi ktatavarthi mentioned this issue Sep 30, 2022
Closed
13 tasks
@jukzi jukzi mentioned this issue Sep 30, 2022
Closed
jukzi referenced this issue in jukzi/eclipse.platform.text Sep 30, 2022
@EcljpseB0T
try to fix AsyncContentAssistTest.testCompleteActivationChar() #35
0842118 
forceFocus() seem to be not reliable that the control receives the key
event.
jukzi referenced this issue in jukzi/eclipse.platform.text Oct 4, 2022
@EcljpseB0T
try to fix AsyncContentAssistTest.testCompleteActivationChar() #35
2864a58 
forceFocus() seem to be not reliable that the control receives the key
event.
jukzi referenced this issue in eclipse-platform/eclipse.platform.text Oct 4, 2022
@EcljpseB0T @jukzi
try to fix AsyncContentAssistTest.testCompleteActivationChar() #35
22d9da2 
forceFocus() seem to be not reliable that the control receives the key
event.
@ktatavarthi
Copy link
Member Author

ktatavarthi commented Nov 18, 2022 •
edited
Loading

The below tests fail in the build I20221117-1330 on Windows

  • org.eclipse.jface.text.tests.contentassist.AsyncContentAssistTest.testCompleteActivationChar
  • org.eclipse.jface.text.tests.contentassist.ContextInformationPresenterTest.testContextInfo_withStyledTextPresentation
  • org.eclipse.jface.text.tests.contentassist.ContextInformationTest.testContextInfo
  • org.eclipse.jface.text.tests.contentassist.ContextInformationTest.testContextInfo_hide_keyEsc
  • org.eclipse.jface.text.tests.contentassist.ContextInformationTest.testContextInfo_hide_validRange

@ktatavarthi ktatavarthi mentioned this issue Nov 18, 2022
Closed
13 tasks
@ktatavarthi
Copy link
Member Author

The below tests fail in the build I20221123-1800 on Windows

org.eclipse.jface.text.tests.contentassist.AsyncContentAssistTest.testCompleteActivationChar
org.eclipse.jface.text.tests.contentassist.ContextInformationPresenterTest.testContextInfo_withStyledTextPresentation
org.eclipse.jface.text.tests.contentassist.ContextInformationTest.testContextInfo_hide_keyEsc
org.eclipse.jface.text.tests.contentassist.ContextInformationTest.testContextInfo_hide_validRange

@ktatavarthi ktatavarthi mentioned this issue Nov 25, 2022
Closed
13 tasks
@jukzi
Copy link
Contributor

jukzi commented May 26, 2023

ContextInformationTest's randomly fails locally on WIndows every ~2nd time. for MAC and Linux ContextInformationTest.testContextInfo_hide_focusOut() is already disabled.

jukzi referenced this issue in jukzi/eclipse.platform.text May 26, 2023
@EcljpseB0T
fix ContextInformationTest #35
8ea681f 
Identify correct shell instead of taking random one.
jukzi referenced this issue in jukzi/eclipse.platform.text May 26, 2023
@EcljpseB0T
fix ContextInformationTest #35
d9170ee 
Identify correct shell instead of taking random one.
jukzi referenced this issue in jukzi/eclipse.platform.text May 26, 2023
@EcljpseB0T
fix ContextInformationTest, AsyncContentAssistTest #35
478b69f 
Identify correct shell instead of taking random one.
jukzi referenced this issue in jukzi/eclipse.platform.text May 26, 2023
@EcljpseB0T
fix ContextInformationTest, AsyncContentAssistTest, CompletionTest #35
f6655f7 
Identify correct shell instead of taking random one.
jukzi referenced this issue in jukzi/eclipse.platform.text May 26, 2023
@EcljpseB0T
fix ContextInformationTest, AsyncContentAssistTest, CompletionTest #35
8fa5550 
Identify correct shell instead of taking random one.
jukzi referenced this issue in eclipse-platform/eclipse.platform.text May 26, 2023
@EcljpseB0T @jukzi
fix ContextInformationTest, AsyncContentAssistTest, CompletionTest #35
9e6b830 
Identify correct shell instead of taking random one.
@jukzi
Copy link
Contributor

jukzi commented Jun 1, 2023

Still an error:
https://download.eclipse.org/eclipse/downloads/drops4/I20230531-1800/testresults/html/org.eclipse.jface.text.tests_ep428I-unit-win32-java17_win32.win32.x86_64_17.html

java.lang.AssertionError: Not unique new shell found expected:<1> but was:<0>
at org.junit.Assert.assertEquals(Assert.java:647)
at org.eclipse.jface.text.tests.contentassist.AbstractContentAssistTest.findNewShell(AbstractContentAssistTest.java:235)
at org.eclipse.jface.text.tests.contentassist.AsyncContentAssistTest.testCompleteActivationChar(AsyncContentAssistTest.java:182)

jukzi referenced this issue in jukzi/eclipse.platform.text Jun 1, 2023
@EcljpseB0T
testCompleteActivationChar: single threaded #35
20764b6
jukzi referenced this issue in eclipse-platform/eclipse.platform.text Jun 2, 2023
@EcljpseB0T @jukzi
testCompleteActivationChar: single threaded #35
b37a605
@jukzi
Copy link
Contributor

jukzi commented Jun 21, 2023

still randomly failing on win
https://download.eclipse.org/eclipse/downloads/drops4/I20230620-1800/testresults/html/org.eclipse.jface.text.tests_ep429I-unit-win32-java17_win32.win32.x86_64_17.html

java.lang.AssertionError: Not unique new shell found expected:<1> but was:<0>
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotEquals(Assert.java:835)
at org.junit.Assert.assertEquals(Assert.java:647)
at org.eclipse.jface.text.tests.contentassist.AbstractContentAssistTest.findNewShell(AbstractContentAssistTest.java:235)

@laeubi laeubi transferred this issue from eclipse-platform/eclipse.platform.text Jun 28, 2023
@jukzi
Copy link
Contributor

jukzi commented Jul 14, 2023

still randomly failing on win
https://download.eclipse.org/eclipse/downloads/drops4/I20230713-1800/testresults/html/org.eclipse.jface.text.tests_ep429I-unit-win32-java17_win32.win32.x86_64_17.html

java.lang.AssertionError: Not unique new shell found expected:<1> but was:<0>
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotEquals(Assert.java:835)
at org.junit.Assert.assertEquals(Assert.java:647)
at org.eclipse.jface.text.tests.contentassist.AbstractContentAssistTest.findNewShell(AbstractContentAssistTest.java:235)
at org.eclipse.jface.text.tests.contentassist.AsyncContentAssistTest.testCompleteActivationChar(AsyncContentAssistTest.java:161)

@jukzi jukzi added the help wanted Extra attention is needed label Aug 21, 2023
@jukzi
Copy link
Contributor

jukzi commented Aug 21, 2023

Added help_wanted flag, as this is one frequently shows up in I-builds.

@iloveeclipse
Copy link
Member

I would propose to disable AsyncContentAssistTest.testCompleteActivationChar. It makes no sense to keep the test failing for years.

@jukzi
Copy link
Contributor

jukzi commented Aug 21, 2023

I would propose to disable AsyncContentAssistTest.testCompleteActivationChar.

ok for me

iloveeclipse added a commit to iloveeclipse/eclipse.platform.ui that referenced this issue Aug 21, 2023
@iloveeclipse
Disable unstable testCompleteActivationChar() on Windows
0dee39e 
See eclipse-platform#890
@iloveeclipse iloveeclipse mentioned this issue Aug 21, 2023
Merged
iloveeclipse added a commit that referenced this issue Aug 21, 2023
@iloveeclipse
Disable unstable testCompleteActivationChar() on Windows
fa99e88 
See #890
@jukzi jukzi added the test junit test related things label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed test junit test related things
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iloveeclipse @ktatavarthi @jukzi