Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Version Number to accomodate #1132 #1181

Closed

Conversation

Wittmaxi
Copy link

As discussed in #1132

@Wittmaxi
Copy link
Author

@vogella

@vogella
Copy link
Contributor

vogella commented Sep 29, 2023

I think you plan to keep the API stable? So only increase the minor segment by 100

@vogella
Copy link
Contributor

vogella commented Sep 29, 2023

3.17.200 -> 3.17.300

@Wittmaxi Wittmaxi force-pushed the MW_increase_version_number branch from 44a3cf3 to 2583bac Compare September 29, 2023 11:26
@Wittmaxi
Copy link
Author

Yes, you are absolutely right, the API should stay stable. I have updated my PR :) @vogella

Copy link
Member

@iloveeclipse iloveeclipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is not needed, version was already bumped for 4.30 via 324229d

@vogella
Copy link
Contributor

vogella commented Sep 29, 2023

@Wittmaxi so the build failure of #1132 is not related to missing version increase?

@HeikoKlare
Copy link
Contributor

I think the build there is failing, because the FindAndReplace class is currently marked public, which would be a public API change. Reducing its visibility will resolve the version problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants