Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove System theme #142

Merged

Conversation

mickaelistria
Copy link
Contributor

The goal of the System theme was to fill the gap between default SWT
behavior and modern practices. But since such modern practices are
better to be built in SWT, it seems irrelevant and potentially harmful
to maintain the System theme as a workaround; efforts would be better
placed directly in SWT.

@mickaelistria mickaelistria linked an issue Jun 14, 2022 that may be closed by this pull request
The goal of the System theme was to fill the gap between default SWT
behavior and modern practices. But since such modern practices are
better to be built in SWT, it seems irrelevant and potentially harmful
to maintain the System theme as a workaround; efforts would be better
placed directly in SWT.
@mickaelistria mickaelistria merged commit 9328b2d into eclipse-platform:master Jun 14, 2022
@vogella
Copy link
Contributor

vogella commented Jun 15, 2022

@mickaelistria what happens if the user uses the system theme and updates his IDE? Please test this case otherwise the IDE might become unusable for former system theme users.

@mickaelistria
Copy link
Contributor Author

It fallbacks to Light theme.

@Phillipus
Copy link
Contributor

efforts would be better placed directly in SWT.

Are those efforts underway? Just curious so I can test/help.

@vogella
Copy link
Contributor

vogella commented Jun 16, 2022

@Phillipus #14 could use some help / testing

@mickaelistria
Copy link
Contributor Author

Are those efforts underway?

We recently updated the default CTabRenderer in SWT; and will probably make more changes. This CTabRenderer is the main part of SWT that is impacting them and that is not native. If you have suggestions of how to enhance it, please report to SWT; usually building a case of why the improvement should be made default (eg comparing with native win32/gtk/cocoa widgets, comparing with recommendations from those given reference frameworks, or other comparable ones).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable or fix System theme on Windows
3 participants