Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace anonymous runnable class with lambda #1459

Merged
merged 2 commits into from
Jan 9, 2024
Merged

replace anonymous runnable class with lambda #1459

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7875f69
replace anonymous runnable class with lambda
elsazac Jan 3, 2024
605c868
fixup: Addressed the review comments
elsazac Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions ...text/src/org/eclipse/jface/internal/text/link/contentassist/CompletionProposalPopup2.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -872,18 +872,14 @@ public void processEvent(VerifyEvent e) {
private void filterProposals() {
++ fInvocationCounter;
Control control= fViewer.getTextWidget();
control.getDisplay().asyncExec(new Runnable() {
long fCounter= fInvocationCounter;
@Override
public void run() {

if (fCounter != fInvocationCounter)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This condition not being always true (before) but being always true (after)

return;
if (fInvocationProcessedCounter == fInvocationCounter)
return;
long fCounter= fInvocationCounter;
control.getDisplay().asyncExec(() -> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not equivalent and will most likely cause bugs:

if (fCounter != fInvocationCounter)
return;
if (fInvocationProcessedCounter == fInvocationCounter)
return;

doFilterProposals();
}
doFilterProposals();
});
}

Expand Down
Loading