Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify collection emptiness check #1462

Merged
merged 1 commit into from
Jan 4, 2024
Merged

simplify collection emptiness check #1462

merged 1 commit into from
Jan 4, 2024

Conversation

elsazac
Copy link
Member

@elsazac elsazac commented Jan 4, 2024

Use isEmpty() API of collections to simplify the emptiness check. reduces one extra comparison.

@elsazac
simplify collection emptiness check
21dd3a9 
Use isEmpty() API of collections to simplify the emptiness check.reduces
one extra comparison.
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

Test Results

   900 files  +    1     900 suites  +1   1h 6m 39s ⏱️ + 29m 25s
 7 470 tests ±    0   7 317 ✅ +    1  153 💤 ±  0  0 ❌  - 1 
23 559 runs  +1 577  23 048 ✅ +1 457  511 💤 +121  0 ❌  - 1 

Results for commit 21dd3a9. ± Comparison against base commit f897258.

akurtakov
akurtakov approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@akurtakov akurtakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@akurtakov akurtakov merged commit ba8b454 into eclipse-platform:master Jan 4, 2024
16 checks passed
@HeikoKlare HeikoKlare mentioned this pull request Jan 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akurtakov akurtakov akurtakov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elsazac @akurtakov