Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leverage type inference for generics #1463

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Leverage type inference for generics #1463

merged 1 commit into from
Jan 4, 2024

Conversation

elsazac
Copy link
Member

@elsazac elsazac commented Jan 4, 2024

Use <> for type inference wherever applicable

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024 •
edited
Loading

Test Results

   899 files   -     1     899 suites   - 1   37m 45s ⏱️ - 7m 6s
 7 470 tests ±    0   7 316 ✅ ±    0  153 💤 ±  0  1 ❌ ±0 
21 982 runs   - 1 577  21 591 ✅  - 1 456  390 💤  - 121  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit b205986. ± Comparison against base commit ba8b454.

♻️ This comment has been updated with latest results.

@merks
Copy link
Contributor

merks commented Jan 4, 2024

Please don't change generated files, i.e., files with * @generated in the Javadoc.

I will apply the cleanup to projects with models in them and regenerate them to ensure they remain consistent.

@merks
Copy link
Contributor

merks commented Jan 4, 2024

FYI, I've done a general cleanup and regeneration via this PR:

#1465

merks
merks requested changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the changes to generated files. Those are handled by this PR:

#1465

@elsazac
Leverage type inference for generics
b205986 
Use <> for type inference wherever applicable
@elsazac elsazac force-pushed the refactor_generictypeinference branch from 20bcbf5 to b205986 Compare January 4, 2024 08:48
@elsazac
Copy link
Member Author

elsazac commented Jan 4, 2024

Thanks for the review @akurtakov @merks .
I reverted all the changes in org.eclipse.e4.ui.model.workbench bundle, assuming that's where all the generated code go ( I never knew they were generated code). Let me know if this is fine.

merks
merks approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine now. Thanks. 😄

@akurtakov akurtakov merged commit f1d24a6 into eclipse-platform:master Jan 4, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akurtakov akurtakov akurtakov left review comments

@merks merks merks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elsazac @merks @akurtakov