remove stale bundle dependencies #1470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
requested changes
Jan 5, 2024
| @@ -9,9 +9,7 @@ Bundle-Vendor: %Plugin.providerName | |||
| Bundle-Localization: plugin | |||
| Export-Package: org.eclipse.ui.internal;x-internal:=true | |||
| Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)", | |||
| org.eclipse.swt;bundle-version="[3.124.0,4.0.0)";visibility:=reexport, | |||
There was a problem hiding this comment.
Reexports can not be removed even if they are unused
There was a problem hiding this comment.
Thanks for the review. reverted the SWT entry that has the reexport visibility. please have a look.
btw I was using the PDE tool to clean up the dependencies. Do you think the tool needs to care about the visibility attribute?
There was a problem hiding this comment.
It should have an option to keep such entries, in general one can remove, but for eclipse platform it would be an API break, so if you can enhance/improve it it would be great.
iloveeclipse
requested changes
Jan 5, 2024
|
See my comment above, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
identified by
organise manifesttool from PDE.