Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable VirtualLazyTreeViewerTest#testContains() on Mac #1183 #1572

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

HeikoKlare
Copy link
Contributor

The test case org.eclipse.jface.tests.viewers.VirtualLazyTreeViewerTest.testContains is randomly failing on Mac. Several other test cases accessing the data of items in a tree viewer with lazy content provider have been disabled on Mac due to some issue with the availability of the item data (bug 347491).

Since there is no value in executing this test when the functionality is known to be broken and thus other related test cases are already disabled, this change disables the random failing test.

Fixes #1183

@HeikoKlare HeikoKlare marked this pull request as ready for review January 26, 2024 13:07
Copy link
Contributor

github-actions bot commented Jan 26, 2024

Test Results

   918 files  ±0     918 suites  ±0   48m 20s ⏱️ +22s
 7 439 tests ±0   7 287 ✅ ±0  152 💤 ±0  0 ❌ ±0 
23 466 runs  ±0  22 958 ✅ ±0  508 💤 ±0  0 ❌ ±0 

Results for commit bfe5cfc. ± Comparison against base commit e6a8072.

♻️ This comment has been updated with latest results.

…orm#1183

The test case
org.eclipse.jface.tests.viewers.VirtualLazyTreeViewerTest.testContains
is randomly failing on Mac. Several other test cases accessing the data
of items in a tree viewer with lazy content provider have been disabled
on Mac due to some issue with the availability of the item data (bug
347491).

Since there is no value in executing this test when the functionality is
known to be broken and thus other related test cases are already
disabled, this change disables the random failing test.

Fixes eclipse-platform#1183
@HeikoKlare HeikoKlare merged commit ce26ac0 into eclipse-platform:master Jan 29, 2024
16 checks passed
@HeikoKlare HeikoKlare deleted the issue-1183 branch January 29, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random failing VirtualLazyTreeViewerTest.testContains
1 participant