Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lost StatusLine message #1706

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

jukzi
Copy link
Contributor

@jukzi jukzi commented Feb 20, 2024

StatusLine message is used both as ProgressMonitor and to show problems.

When a problem message is reset while ProgressMonitor is running the progress message was lost.
When a ProgressMonitor finished while a problem was shown the problem message was lost;

Happened for example while opening Quick-Type Hierarchy within <500ms after selecting a line that had a Problem marker.

@jukzi
Copy link
Contributor Author

jukzi commented Feb 20, 2024

Example with fix: (warning is preserved):
StatusLine text

Copy link
Contributor

github-actions bot commented Feb 20, 2024

Test Results

   918 files     918 suites   46m 8s ⏱️
 7 452 tests  7 300 ✅ 151 💤 1 ❌
23 505 runs  22 999 ✅ 505 💤 1 ❌

For more details on these failures, see this check.

Results for commit 0b041ea.

♻️ This comment has been updated with latest results.

StatusLine message is used both as ProgressMonitor and to show problems.

When a problem message is reset while ProgressMonitor is running the
progress message was lost.
When a ProgressMonitor finished while a problem was shown the problem
message was lost;

Happened for example while opening Quick-Type Hierarchy within <500ms
after selecting a line that had a Problem marker.
@jukzi jukzi force-pushed the fix_StatusLine_message branch from def5bb0 to 0b041ea Compare March 5, 2024 12:36
@jukzi jukzi merged commit adc4b6b into eclipse-platform:master Mar 5, 2024
14 of 16 checks passed
@jukzi jukzi deleted the fix_StatusLine_message branch March 5, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants