Don't wait for jobs in SmartImportTests #1810
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove calls to
waitForJobs(...)
inSmartImportTests
and only join the (now correct)SmartImportJob
instead.Rename
SmartImportWizard::getImportJob
tocreateOrGetConfiguredImportJob
and change its javadoc (the method was doing a lot more than simply retrieving a Job, which is what broke the tests in the first place).Add a new method
SmartImportWizard::getCurrentImportJob
that merely returns the current job and join that job in the tests. Before this PR, a new job was being created and joined, which didn't make sense since that job was never started in the first place.Fixes: #1427
Fixes: #1807