Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find/Replace overlay: reorder buttons #2016

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

Wittmaxi
Copy link

@Wittmaxi Wittmaxi commented Jul 1, 2024

reorder buttons such that the "whole words" button is not in front,
making the taborder more intuitive in the case that whole word search is
not supported in the current state.

fixes #1998

how to test

Ensure that the whole words button is not first in line
grafik

@Wittmaxi
Copy link
Author

Wittmaxi commented Jul 1, 2024

@jukzi please check

Copy link
Contributor

github-actions bot commented Jul 1, 2024

Test Results

 1 815 files  ±0   1 815 suites  ±0   1h 31m 59s ⏱️ +36s
 7 663 tests ±0   7 435 ✅ ±0  228 💤 ±0  0 ❌ ±0 
24 150 runs  ±0  23 401 ✅ ±0  749 💤 ±0  0 ❌ ±0 

Results for commit 2f51df0. ± Comparison against base commit 7011d80.

♻️ This comment has been updated with latest results.

@Wittmaxi Wittmaxi force-pushed the MW_reorder_buttons branch from 153c5d7 to c2963ba Compare July 1, 2024 12:57
reorder buttons such that the "whole words" button is not in front,
making the taborder more intuitive in the case that whole word search is
not supported in the current state.

fixes eclipse-platform#1998
@HeikoKlare HeikoKlare force-pushed the MW_reorder_buttons branch from c2963ba to 2f51df0 Compare July 3, 2024 16:22
Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Trivial change to fix #1998.

@HeikoKlare HeikoKlare merged commit d67d6c7 into eclipse-platform:master Jul 3, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find/Replace overlay: reorder regexp/whole word button
2 participants