Update Notification API to use modern looking X #2037
Conversation
|
can you please post before and after screenshots? |
You see the icons here: https://github.com/eclipse-platform/eclipse.platform.ui/pull/2037/files. It this sufficient? |
The find/replace overlay introduces a new close icon similar to the close icon used for the tab folder from https://bugs.eclipse.org/bugs/show_bug.cgi?id=575395 This pull request updates the notification close icon which still looks like the old tab icon before the change in https://bugs.eclipse.org/bugs/show_bug.cgi?id=575395 and does not fit anymore in the overall look and feel. A follow-up PR could also update the active folder but find a new "reddisch" color would require more testing on the different OS, while with the regular icon we can build on the testing of eclipse-platform#1991 Fixes: eclipse-platform#2035
vogella
force-pushed
the
notification-close-icon-regular-case
branch
from
6b52ee1 to
e8de8bb
Compare
|
I meant screenshot of the notification before and after. |
|
Should we also update the .images repository? |
Yes please. |
|
New Light:
New Dark:
Old Light:
Old Dark:
As you notice the notification ignores the styling, independent of the icon. I never noticed that before that that is an unrelated issue. |
|
I just tested the PR and with my setup (running the In any case, the icon looks fine for me, even though it could be a bit lighter. |
thanks :-) |
@HeikoKlare once you add your svg to the image repo, can you also also add a copy to the notification project? |
I have already added the close icon for the find/replay overlay to the images repo (eclipse-platform/eclipse.platform.images#80), but I can, of course, create another PR for also adding the icon to the jface.notifications project. When trying to do so, I found that there is also an "active" version of the icon, which is used when hovering over it. We need to adapt this too, as currently the old icon is still used when hovering (and I do not think that we can easily get rid of it, as we hovering feedback has to be implemented in some way): I will have a look and try to provide a proper new "active" icon. |
|
@HeikoKlare related to my report in #2043 |
Thanks! I missed that one. |
Updates the icons used by JFace notifications. Also removes the (unused and equal) disabled version of the icons. See eclipse-platform/eclipse.platform.ui#2037 See eclipse-platform/eclipse.platform.ui#2048
Updates the icons used by JFace notifications. Also removes the (unused and equal) disabled version of the icons. See eclipse-platform/eclipse.platform.ui#2037 See eclipse-platform/eclipse.platform.ui#2048
The find/replace overlay introduces a new close icon similar to the close icon used for the tab folder from
https://bugs.eclipse.org/bugs/show_bug.cgi?id=575395
This pull request updates the notification close icon which still looks like the old tab icon before the change in
https://bugs.eclipse.org/bugs/show_bug.cgi?id=575395 and does not fit anymore in the overall look and feel.
A follow-up PR could also update the active folder but find a new "reddisch" color would require more testing on the different OS, while with the regular icon we can build on the testing of #1991
Fixes: #2035