Find/Replace Overlay: close when escape is pressed in the editor #2044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wittmaxi
force-pushed
the
MW_close_overlay_even_if_in_editor
branch
from
1ca070c to
33ea742
Compare
HeikoKlare
approved these changes
Jul 6, 2024
There was a problem hiding this comment.
Works as expected and, in my opinion, significantly improves user experience 👍
The implementation looks sound. I was just thinking whether there might be situations in which adding a key listener to the target widget/editor could lead to some kind of key-handling conflicts, but since it's just a listener, I don't see a risk for that to happen.
...kbench.texteditor/src/org/eclipse/ui/internal/findandreplace/overlay/FindReplaceOverlay.java
Outdated
Show resolved
Hide resolved
Wittmaxi
force-pushed
the
MW_close_overlay_even_if_in_editor
branch
from
33ea742 to
03eaebe
Compare
When escape is pressed inside of the editor which is targeted by the find/replace overlay, the overlay now closes. fixes eclipse-platform#2033
HeikoKlare
force-pushed
the
MW_close_overlay_even_if_in_editor
branch
from
03eaebe to
816c687
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When escape is pressed inside of the editor which is targeted by the find/replace overlay, the overly now closes.
fixes #2033